All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fs/ext2: fix double quoted label
Date: Mon, 21 Nov 2016 15:23:55 -0500	[thread overview]
Message-ID: <20161121202355.pyyrkkjuy3eelyy7@gportay> (raw)
In-Reply-To: <20161121211528.0c4a9928@free-electrons.com>

Hi Thomas,

On Mon, Nov 21, 2016 at 09:15:28PM +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 21 Nov 2016 11:15:29 -0500, Ga?l PORTAY wrote:
> > Since the commit 6dd7bbb59134799ed3d7343f238b3b02592faebf, the label does
> > not need anymore to be quoted. Even worse it *must* not be simple-quoted,
> > unless the label will contain the double-quotes from the config variable
> > BR2_TARGET_ROOTFS_EXT2_LABEL.
> > 
> > The commit mentionned above has replaced echo by printf:
> > -	echo "$$(ROOTFS_$(2)_CMD)" >> $$(FAKEROOT_SCRIPT)
> > +	$$(call PRINTF,$$(ROOTFS_$(2)_CMD)) >> $$(FAKEROOT_SCRIPT)
> > 
> > Since this commit the rootfs label contains extra double-quotes.
> > $ blkid
> > /dev/mmcblk0: LABEL=""BR 2016.08"" UUID="xxx"
> >                      ^          ^
> > 
> > With this fix, the extra double-quotes have disappeared:
> > /dev/mmcblk0: LABEL="BR 2016.11-rc2" UUID="yyy"
> > 
> > Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  fs/ext2/ext2.mk | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> Applied to master, thanks.
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

Thanks

  reply	other threads:[~2016-11-21 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 16:15 [Buildroot] [PATCH] fs/ext2: fix double quoted label Gaël PORTAY
2016-11-21 20:15 ` Thomas Petazzoni
2016-11-21 20:23   ` Gaël PORTAY [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-11-16 19:55 Gaël PORTAY
2016-11-16 19:55 ` Gaël PORTAY
2016-11-16 22:58   ` Arnout Vandecappelle
2016-11-17 17:48     ` Gaël PORTAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121202355.pyyrkkjuy3eelyy7@gportay \
    --to=gael.portay@savoirfairelinux.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.