From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755776AbcKVImT (ORCPT ); Tue, 22 Nov 2016 03:42:19 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37925 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755755AbcKVImR (ORCPT ); Tue, 22 Nov 2016 03:42:17 -0500 Date: Tue, 22 Nov 2016 09:42:14 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Martin Kaiser Cc: Sascha Hauer , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Message-ID: <20161122084214.fxn26mfur7wwlgs2@pengutronix.de> References: <1479801258-3765-1-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1479801258-3765-1-git-send-email-martin@kaiser.cx> User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2016 at 08:54:18AM +0100, Martin Kaiser wrote: > The HM and TM fields in the LCDC DMA Control Register are 7 bits wide. > Use the correct mask to allow setting all possible bits. > > Signed-off-by: Martin Kaiser > --- > > This bug was discovered on a board that uses DMACR_TM(16). We ended up > with TM==0 in the register, the upper three bits were filtered out. > > The LCD DMA Control Register is described in section 33.3.16 of the > IMX25 reference manual. For the MX1 which is also supported by this driver, the definitions are right. So this needs a more sophisticated patch. Also I wonder why the register definition is in include/linux/platform_data and not in the driver directly. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Date: Tue, 22 Nov 2016 08:42:14 +0000 Subject: Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Message-Id: <20161122084214.fxn26mfur7wwlgs2@pengutronix.de> List-Id: References: <1479801258-3765-1-git-send-email-martin@kaiser.cx> In-Reply-To: <1479801258-3765-1-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Martin Kaiser Cc: Sascha Hauer , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Nov 22, 2016 at 08:54:18AM +0100, Martin Kaiser wrote: > The HM and TM fields in the LCDC DMA Control Register are 7 bits wide. > Use the correct mask to allow setting all possible bits. >=20 > Signed-off-by: Martin Kaiser > --- >=20 > This bug was discovered on a board that uses DMACR_TM(16). We ended up > with TM=3D0 in the register, the upper three bits were filtered out. >=20 > The LCD DMA Control Register is described in section 33.3.16 of the > IMX25 reference manual. For the MX1 which is also supported by this driver, the definitions are right. So this needs a more sophisticated patch. Also I wonder why the register definition is in include/linux/platform_data and not in the driver directly. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ |