From: Stefan Hajnoczi <stefanha@gmail.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com,
xiecl.fnst@cn.fujitsu.com, wency@cn.fujitsu.com,
Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
mreitz@redhat.com, stefanha@redhat.com,
Amit Shah <amit.shah@redhat.com>,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH RFC 0/7] COLO block replication supports shared disk case
Date: Tue, 22 Nov 2016 10:33:40 +0000 [thread overview]
Message-ID: <20161122103340.GA5970@stefanha-x1.localdomain> (raw)
In-Reply-To: <1476971860-20860-1-git-send-email-zhang.zhanghailiang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]
On Thu, Oct 20, 2016 at 09:57:33PM +0800, zhanghailiang wrote:
> COLO block replication doesn't support the shared disk case,
> Here we try to implement it.
>
> Just as the scenario of non-shared disk block replication,
> we are going to implement block replication from many basic
> blocks that are already in QEMU.
> The architecture is:
>
> virtio-blk || .----------
> / || | Secondary
> / || '----------
> / || virtio-blk
> / || |
> | || replication(5)
> | NBD --------> NBD (2) |
> | client || server ---> hidden disk <-- active disk(4)
> | ^ || |
> | replication(1) || |
> | | || |
> | +-----------------' || |
> (3) |drive-backup sync=none || |
> --------. | +-----------------+ || |
> Primary | | | || backing |
> --------' | | || |
> V | |
> +-------------------------------------------+ |
> | shared disk | <----------+
> +-------------------------------------------+
> 1) Primary writes will read original data and forward it to Secondary
> QEMU.
> 2) The hidden-disk will buffers the original content that is modified
> by the primary VM. It should also be an empty disk, and
> the driver supports bdrv_make_empty() and backing file.
> 3) Primary write requests will be written to Shared disk.
> 4) Secondary write requests will be buffered in the active disk and it
> will overwrite the existing sector content in the buffe
This design looks good. I have not reviewed the patches in detail but
will review the next revision.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-11-22 10:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 13:57 [Qemu-devel] [PATCH RFC 0/7] COLO block replication supports shared disk case zhanghailiang
2016-10-20 13:57 ` [Qemu-devel] [PATCH RFC 1/7] docs/block-replication: Add description for shared-disk case zhanghailiang
2016-10-25 9:03 ` Changlong Xie
2016-11-28 5:13 ` Hailiang Zhang
2016-11-28 6:00 ` Changlong Xie
2016-11-28 5:58 ` Hailiang Zhang
2016-10-20 13:57 ` [Qemu-devel] [PATCH RFC 2/7] block-backend: Introduce blk_root() helper zhanghailiang
2016-10-25 9:58 ` Changlong Xie
2016-12-05 2:41 ` Hailiang Zhang
2016-10-20 13:57 ` [Qemu-devel] [PATCH RFC 3/7] replication: add shared-disk and shared-disk-id options zhanghailiang
2016-10-25 10:01 ` Changlong Xie
2016-12-05 3:08 ` Hailiang Zhang
2016-10-26 1:58 ` Changlong Xie
2016-10-20 13:57 ` [Qemu-devel] [PATCH RFC 4/7] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint() zhanghailiang
2016-10-26 1:40 ` Changlong Xie
2016-12-05 3:41 ` Hailiang Zhang
2016-10-20 13:57 ` [Qemu-devel] [PATCH RFC 5/7] replication: fix code logic with the new shared_disk option zhanghailiang
2016-10-20 13:57 ` [Qemu-devel] [PATCH RFC 6/7] replication: Implement block replication for shared disk case zhanghailiang
2016-10-20 13:57 ` [Qemu-devel] [PATCH RFC 7/7] nbd/replication: implement .bdrv_get_info() for nbd and replication driver zhanghailiang
2016-10-20 15:34 ` Eric Blake
2016-10-24 2:44 ` Hailiang Zhang
2016-10-26 2:06 ` [Qemu-devel] [PATCH RFC 0/7] COLO block replication supports shared disk case Changlong Xie
2016-11-22 10:33 ` Stefan Hajnoczi [this message]
2016-11-23 1:47 ` [Qemu-devel] [Qemu-block] " Hailiang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122103340.GA5970@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=xiecl.fnst@cn.fujitsu.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.