From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756531AbcKVQlU (ORCPT ); Tue, 22 Nov 2016 11:41:20 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:53622 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756512AbcKVQlS (ORCPT ); Tue, 22 Nov 2016 11:41:18 -0500 From: Liviu Dudau To: Eric Engestrom Cc: David Airlie , DRI devel , LKML , Rob Clark , Jani Nikula , Daniel Vetter Subject: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Date: Tue, 22 Nov 2016 16:41:06 +0000 Message-Id: <20161122164106.31852-1-Liviu.Dudau@arm.com> X-Mailer: git-send-email 2.10.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drm_get_format_name() de-references the buf parameter without checking if the pointer was not NULL. Given that the function is EXPORT-ed, lets sanitise the parameters before proceeding. Fixes: b3c11ac267d461d3d5 ("drm: move allocation out of drm_get_format_name()) Cc: Eric Engestrom Cc: Rob Clark Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_fourcc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 90d2cc8..0a3ff0b 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -85,6 +85,9 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format); */ const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf) { + if (!buf) + return NULL; + snprintf(buf->str, sizeof(buf->str), "%c%c%c%c %s-endian (0x%08x)", printable_char(format & 0xff), -- 2.10.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Date: Tue, 22 Nov 2016 16:41:06 +0000 Message-ID: <20161122164106.31852-1-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by gabe.freedesktop.org (Postfix) with ESMTPS id A25EE6E318 for ; Tue, 22 Nov 2016 16:41:16 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Engestrom Cc: Daniel Vetter , LKML , DRI devel , Jani Nikula List-Id: dri-devel@lists.freedesktop.org ZHJtX2dldF9mb3JtYXRfbmFtZSgpIGRlLXJlZmVyZW5jZXMgdGhlIGJ1ZiBwYXJhbWV0ZXIgd2l0 aG91dCBjaGVja2luZwppZiB0aGUgcG9pbnRlciB3YXMgbm90IE5VTEwuIEdpdmVuIHRoYXQgdGhl IGZ1bmN0aW9uIGlzIEVYUE9SVC1lZCwgbGV0cwpzYW5pdGlzZSB0aGUgcGFyYW1ldGVycyBiZWZv cmUgcHJvY2VlZGluZy4KCkZpeGVzOiBiM2MxMWFjMjY3ZDQ2MWQzZDUgKCJkcm06IG1vdmUgYWxs b2NhdGlvbiBvdXQgb2YgZHJtX2dldF9mb3JtYXRfbmFtZSgpKQpDYzogRXJpYyBFbmdlc3Ryb20g PGVyaWNAZW5nZXN0cm9tLmNoPgpDYzogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgpD YzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KQ2M6IERhbmllbCBWZXR0ZXIg PGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CgpTaWduZWQtb2ZmLWJ5OiBMaXZpdSBEdWRhdSA8TGl2 aXUuRHVkYXVAYXJtLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jIHwgMyAr KysKIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZvdXJjYy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYwppbmRl eCA5MGQyY2M4Li4wYTNmZjBiIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJj Yy5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91cmNjLmMKQEAgLTg1LDYgKzg1LDkgQEAg RVhQT1JUX1NZTUJPTChkcm1fbW9kZV9sZWdhY3lfZmJfZm9ybWF0KTsKICAqLwogY29uc3QgY2hh ciAqZHJtX2dldF9mb3JtYXRfbmFtZSh1aW50MzJfdCBmb3JtYXQsIHN0cnVjdCBkcm1fZm9ybWF0 X25hbWVfYnVmICpidWYpCiB7CisJaWYgKCFidWYpCisJCXJldHVybiBOVUxMOworCiAJc25wcmlu dGYoYnVmLT5zdHIsIHNpemVvZihidWYtPnN0ciksCiAJCSAiJWMlYyVjJWMgJXMtZW5kaWFuICgw eCUwOHgpIiwKIAkJIHByaW50YWJsZV9jaGFyKGZvcm1hdCAmIDB4ZmYpLAotLSAKMi4xMC4yCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK