Hi, On Tue, Nov 15, 2016 at 10:18:52PM +0900, Milo Kim wrote: > IRQ number is only used on requesting the interrupt, so no need to keep > it inside the driver data. > In case of polling, poll_task is valid only when polling thread is > activated. > > Cc: Enric Balletbo i Serra > Signed-off-by: Milo Kim > --- > drivers/power/supply/tps65217_charger.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c > index 04f8322..55a4f34 100644 > --- a/drivers/power/supply/tps65217_charger.c > +++ b/drivers/power/supply/tps65217_charger.c > @@ -46,8 +46,6 @@ struct tps65217_charger { > int prev_ac_online; > > struct task_struct *poll_task; > - > - int irq; Removal of this (and related changes) look ok. The poll_task changes are actually only needed due to Patch 1 (which should be dropped imho). -- Sebastian