From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755549AbcKWAfs (ORCPT ); Tue, 22 Nov 2016 19:35:48 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:49124 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253AbcKWAfq (ORCPT ); Tue, 22 Nov 2016 19:35:46 -0500 Date: Wed, 23 Nov 2016 01:35:05 +0100 From: Andrew Lunn To: Tomas Hlavacek Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Rob Herring , Mark Rutland , Russell King , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] ARM: dts: Add support for Turris Omnia Message-ID: <20161123003505.GL2691@lunn.ch> References: <1479851991.26813.2@smtp.gmail.com> <1479859770-9375-1-git-send-email-tmshlvck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479859770-9375-1-git-send-email-tmshlvck@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts > @@ -0,0 +1,279 @@ > +/* > + * Device Tree file for the Turris Omnia > + * Schematic available at https://www.turris.cz/doc/_media/rtrom01-schema.pdf Hi Tomas Cool that there is a link to the schematics. But please could you put it lower down. It is more likely to be seen if it comes after the copyright and license section. > + sdhci@d8000 { > + pinctrl-names = "default"; > + pinctrl-0 = <&sdhci_pins>; > + status = "okay"; > + > + bus-width = <8>; > + no-1-8-v; > + non-removable; > + }; > +&i2c0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; > + status = "okay"; > + > + i2cmux@70 { > + compatible = "nxp,pca9547"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x70>; > + status = "okay"; > + > + /* Channel 1: Routed to PCIe0/mSATA connector (CN7A). > + * Channel 2: Routed to PCIe1/USB2 connector (CN61A). > + * Channel 3: Routed to PCIe2 connector (CN62A). > + * Channel 4: Routed to SFP+. > + * Channel 5: ATSHA204A at address 0x64. > + * Channel 6: Routed to user pin header CN11. > + */ I've not looked at how the pca9547 works.... Will it instantiate a bus only if there is a node in the device tree with a reg property? What i'm thinking is that it is possible to indicate to the i2c core that a device is on a bus using echo to a file. But this only works if the bus exists. You could for example say using echo that there is an at24 EEPROM on channel 4 and get access to the EEPROM inside the SFP module. But that only works if the i2c bus exists. Does it? No leds? No buttons via gpio-keys? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Wed, 23 Nov 2016 01:35:05 +0100 Subject: [RFC PATCH] ARM: dts: Add support for Turris Omnia In-Reply-To: <1479859770-9375-1-git-send-email-tmshlvck@gmail.com> References: <1479851991.26813.2@smtp.gmail.com> <1479859770-9375-1-git-send-email-tmshlvck@gmail.com> Message-ID: <20161123003505.GL2691@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts > @@ -0,0 +1,279 @@ > +/* > + * Device Tree file for the Turris Omnia > + * Schematic available at https://www.turris.cz/doc/_media/rtrom01-schema.pdf Hi Tomas Cool that there is a link to the schematics. But please could you put it lower down. It is more likely to be seen if it comes after the copyright and license section. > + sdhci at d8000 { > + pinctrl-names = "default"; > + pinctrl-0 = <&sdhci_pins>; > + status = "okay"; > + > + bus-width = <8>; > + no-1-8-v; > + non-removable; > + }; > +&i2c0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; > + status = "okay"; > + > + i2cmux at 70 { > + compatible = "nxp,pca9547"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x70>; > + status = "okay"; > + > + /* Channel 1: Routed to PCIe0/mSATA connector (CN7A). > + * Channel 2: Routed to PCIe1/USB2 connector (CN61A). > + * Channel 3: Routed to PCIe2 connector (CN62A). > + * Channel 4: Routed to SFP+. > + * Channel 5: ATSHA204A at address 0x64. > + * Channel 6: Routed to user pin header CN11. > + */ I've not looked at how the pca9547 works.... Will it instantiate a bus only if there is a node in the device tree with a reg property? What i'm thinking is that it is possible to indicate to the i2c core that a device is on a bus using echo to a file. But this only works if the bus exists. You could for example say using echo that there is an at24 EEPROM on channel 4 and get access to the EEPROM inside the SFP module. But that only works if the i2c bus exists. Does it? No leds? No buttons via gpio-keys? Andrew