All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next] toolchain-external: support gcc < 4.3
Date: Thu, 24 Nov 2016 09:48:41 +0100	[thread overview]
Message-ID: <20161124094841.6f695932@free-electrons.com> (raw)
In-Reply-To: <1c235f78-0f40-c1f5-1ca4-c6e2661f9e33@mind.be>

Hello,

On Thu, 24 Nov 2016 09:39:13 +0100, Arnout Vandecappelle wrote:

> >> When [BR2_TOOLCHAIN_GCC_AT_LEAST] is
> >> empty, we don't do a version check at all in check_gcc_version.
> >>
> >>  Perhaps I should add to that "(previously we errored out)".  
> > 
> > Well, we're still erroring out, but with a 0 exit code. So I must be
> > missing something.  
> 
>  0 is not an error, right?

Hum, right. I think what confused me is that "exit 0" doesn't abort the
build. It exists the sub-shell started by make, with a zero exit code,
so make continues the build. I was thinking it would abort the build
completely, which is why I was confused.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2016-11-24  8:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 11:14 [Buildroot] [PATCH/next] toolchain-external: support gcc < 4.3 Arnout Vandecappelle
2016-11-23 12:22 ` Thomas Petazzoni
2016-11-23 12:27   ` Arnout Vandecappelle
2016-11-23 22:19     ` Thomas Petazzoni
2016-11-23 23:36       ` Arnout Vandecappelle
2016-11-23 22:21 ` Thomas Petazzoni
2016-11-23 23:38   ` Arnout Vandecappelle
2016-11-24  8:01     ` Thomas Petazzoni
2016-11-24  8:39       ` Arnout Vandecappelle
2016-11-24  8:48         ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161124094841.6f695932@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.