From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751675AbcKYIT7 (ORCPT ); Fri, 25 Nov 2016 03:19:59 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33862 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbcKYITv (ORCPT ); Fri, 25 Nov 2016 03:19:51 -0500 Date: Fri, 25 Nov 2016 09:19:47 +0100 From: Ingo Molnar To: peterz@infradead.org, tglx@linutronix.de, tim.c.chen@linux.intel.com, hpa@zytor.com, srinivas.pandruvada@linux.intel.com, linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/core] x86: Enable Intel Turbo Boost Max Technology 3.0 Message-ID: <20161125081946.GA24513@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * tip-bot for Tim Chen wrote: > Commit-ID: 5e76b2ab36b40ca33023e78725bdc69eafd63134 > Gitweb: http://git.kernel.org/tip/5e76b2ab36b40ca33023e78725bdc69eafd63134 > Author: Tim Chen > AuthorDate: Tue, 22 Nov 2016 12:23:55 -0800 > Committer: Thomas Gleixner > CommitDate: Thu, 24 Nov 2016 20:44:19 +0100 > > x86: Enable Intel Turbo Boost Max Technology 3.0 This patch doesn't build: Note that this patch has to be redone anyway, as it won't even build: > +#include > +#include > +#include > +#include > +#include > +#include > +#include arch/x86/kernel/itmt.c:26:23: fatal error: asm/mutex.h: No such file or directory > +config SCHED_ITMT > + bool "Intel Turbo Boost Max Technology (ITMT) scheduler support" > + depends on SCHED_MC && CPU_SUP_INTEL && X86_INTEL_PSTATE > + ---help--- > + ITMT enabled scheduler support improves the CPU scheduler's decision > + to move tasks to cpu core that can be boosted to a higher frequency > + than others. It will have better performance at a cost of slightly > + increased overhead in task migrations. If unsure say N here. Argh, so the 'itmt' name really sucks as well - could we please make it something more obvious - like SCHED_INTEL_TURBO or so - and similarly rename the file as well? The sched_intel_turbo.c file could thus host all things related to scheduler support of turbo frequencies - it shouldn't be named after the Intel acronym of the day... Thanks, Ingo