From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754181AbcKYIoA (ORCPT ); Fri, 25 Nov 2016 03:44:00 -0500 Received: from botnar.kaiser.cx ([176.28.20.183]:56838 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752669AbcKYInQ (ORCPT ); Fri, 25 Nov 2016 03:43:16 -0500 Date: Fri, 25 Nov 2016 09:43:03 +0100 From: Martin Kaiser To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sascha Hauer Subject: Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Message-ID: <20161125084303.GA14156@botnar.kaiser.cx> References: <1479801258-3765-1-git-send-email-martin@kaiser.cx> <20161122084214.fxn26mfur7wwlgs2@pengutronix.de> <20161123093113.GA10071@botnar.kaiser.cx> <20161123095052.u63j26ixgc54qhkd@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161123095052.u63j26ixgc54qhkd@pengutronix.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thus wrote Uwe Kleine-König (u.kleine-koenig@pengutronix.de): > > ok, understood. I wasn't able to dig up an imx1 specification. Do you > > know if it's publicly available? > http://www.nxp.com/assets/documents/data/en/reference-manuals/MC9328MX1RM.pdf Thanks. > So you put the values to use in the device tree? Then the right thing to > do is to check the device type in the driver and mask accordingly when > the values are written to the hardware. Device tree and platform data contain the entire register, not the individual components. The macros are provided to build the register value from the components, but nobody's using them. > IMHO dropping the macros is the right thing to do. Ok, I'll submit a patch for this. Best regards, Martin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Kaiser Date: Fri, 25 Nov 2016 08:43:03 +0000 Subject: Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Message-Id: <20161125084303.GA14156@botnar.kaiser.cx> List-Id: References: <1479801258-3765-1-git-send-email-martin@kaiser.cx> <20161122084214.fxn26mfur7wwlgs2@pengutronix.de> <20161123093113.GA10071@botnar.kaiser.cx> <20161123095052.u63j26ixgc54qhkd@pengutronix.de> In-Reply-To: <20161123095052.u63j26ixgc54qhkd@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sascha Hauer Thus wrote Uwe Kleine-K=F6nig (u.kleine-koenig@pengutronix.de): > > ok, understood. I wasn't able to dig up an imx1 specification. Do you > > know if it's publicly available? > http://www.nxp.com/assets/documents/data/en/reference-manuals/MC9328MX1RM= .pdf Thanks. > So you put the values to use in the device tree? Then the right thing to > do is to check the device type in the driver and mask accordingly when > the values are written to the hardware. Device tree and platform data contain the entire register, not the individual components. The macros are provided to build the register value from the components, but nobody's using them. > IMHO dropping the macros is the right thing to do. Ok, I'll submit a patch for this. Best regards, Martin