From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753410AbcK0WJI (ORCPT ); Sun, 27 Nov 2016 17:09:08 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:58822 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752203AbcK0WJA (ORCPT ); Sun, 27 Nov 2016 17:09:00 -0500 Date: Sun, 27 Nov 2016 23:08:46 +0100 From: Andrew Lunn To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Michal Hrusecki , Tomas Hlavacek , Bed??icha Ko??atu , Vivien Didelot , Florian Fainelli , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Message-ID: <20161127220846.GH13318@lunn.ch> References: <1480280279-9552-1-git-send-email-afaerber@suse.de> <1480280279-9552-2-git-send-email-afaerber@suse.de> <20161127212709.GD13318@lunn.ch> <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > This driver already supports nearly 30 different Marvell switch > > models. Please document why the marvell,mv88e6176 is special and why > > it needs its own compatible string when the others don't. > > I don't understand. Think about what i said. Why does the 6176 need its own compatible string, when the two 6352s and the 6165 on the zii-devel-b don't have one? And the DIR 665 has a 6171, which does not have a compatible string of its own. The clearfog actually has a 6176, and it seems to work fine without a compatible string. > You as driver author should know that the .data pointer is vital to your > driver Exactly, so if i ask why is it needed, maybe you should stop and think for a while. > you even recently accepted another model that conflicted with > my patch. And think about that also, and you will find the 6390 family, who's first device is 6190, is not compatible with the 6085, and so needs a different compatible string. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Sun, 27 Nov 2016 23:08:46 +0100 Subject: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support In-Reply-To: <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de> References: <1480280279-9552-1-git-send-email-afaerber@suse.de> <1480280279-9552-2-git-send-email-afaerber@suse.de> <20161127212709.GD13318@lunn.ch> <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de> Message-ID: <20161127220846.GH13318@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > This driver already supports nearly 30 different Marvell switch > > models. Please document why the marvell,mv88e6176 is special and why > > it needs its own compatible string when the others don't. > > I don't understand. Think about what i said. Why does the 6176 need its own compatible string, when the two 6352s and the 6165 on the zii-devel-b don't have one? And the DIR 665 has a 6171, which does not have a compatible string of its own. The clearfog actually has a 6176, and it seems to work fine without a compatible string. > You as driver author should know that the .data pointer is vital to your > driver Exactly, so if i ask why is it needed, maybe you should stop and think for a while. > you even recently accepted another model that conflicted with > my patch. And think about that also, and you will find the 6390 family, who's first device is 6190, is not compatible with the 6085, and so needs a different compatible string. Andrew