From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/3] drm: Pull together probe + setup for
	drm_fb_helper
Date: Mon, 28 Nov 2016 08:55:05 +0100
Message-ID: <20161128075505.ac7qamsopzpmll67@phenom.ffwll.local>
References: <20161123140417.18538-1-chris@chris-wilson.co.uk>
 <20161123140417.18538-2-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20161123140417.18538-2-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCBOb3YgMjMsIDIwMTYgYXQgMDI6MDQ6MTZQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IGRybV9mYl9oZWxwZXJfcHJvYmVfY29ubmVjdG9yX21vZGVzKCkgaXMgYWx3YXlzIGNh
bGxlZCBiZWZvcmUKPiBkcm1fc2V0dXBfY3J0Y3MoKSwgc28ganVzdCBtb3ZlIHRoZSBjYWxsIGlu
dG8gZHJtX3NldHVwX2NydGNzIGZvciBhCj4gc21hbGwgYml0IG9mIGNvZGUgY29tcGFjdGlvbi4K
PiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51
az4KClRoaXMgZHJvcHMgZHJtX21vZGVzZXRfbG9ja19hbGwoKSBhcm91bmQgb25lIGNhbGwgb2Yg
ZHJtX3NldHVwX2NydGNzIGFuZApqdXN0IHJlcGxhY2VzIGl0IHdpdGggZGV2LT5tb2RlX2NvbmZp
Zy5tdXRleC4gQnV0IGRybV9zZXR1cF9jcnRjcyBvbmx5Cmxvb2tzIGF0IHByb2JlIHN0YXRlIGFu
ZCBub3QgYXQgbW9kZXNldCBzdGF0ZSwgc28gdGhhdCdzIGFsbCBmaW5lLgoKU2lnbmVkLW9mZi1i
eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZl
cnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgfCAzNyArKysrKysrKysrKy0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyNiBkZWxl
dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIu
YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiBpbmRleCBkMTNjODU2ODI4OTEu
LmExOWFmYzdlY2NkZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBl
ci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IEBAIC0yMDk4LDIw
ICsyMDk4LDE5IEBAIHN0YXRpYyBpbnQgZHJtX3BpY2tfY3J0Y3Moc3RydWN0IGRybV9mYl9oZWxw
ZXIgKmZiX2hlbHBlciwKPiAgCXJldHVybiBiZXN0X3Njb3JlOwo+ICB9Cj4gIAo+IC1zdGF0aWMg
dm9pZCBkcm1fc2V0dXBfY3J0Y3Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcikKPiAr
c3RhdGljIHZvaWQgZHJtX3NldHVwX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxw
ZXIsCj4gKwkJCSAgICB1MzIgd2lkdGgsIHUzMiBoZWlnaHQpCj4gIHsKPiAgCXN0cnVjdCBkcm1f
ZGV2aWNlICpkZXYgPSBmYl9oZWxwZXItPmRldjsKPiAgCXN0cnVjdCBkcm1fZmJfaGVscGVyX2Ny
dGMgKipjcnRjczsKPiAgCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICoqbW9kZXM7Cj4gIAlzdHJ1
Y3QgZHJtX2ZiX29mZnNldCAqb2Zmc2V0czsKPiAgCWJvb2wgKmVuYWJsZWQ7Cj4gLQlpbnQgd2lk
dGgsIGhlaWdodDsKPiAgCWludCBpOwo+ICAKPiAgCURSTV9ERUJVR19LTVMoIlxuIik7Cj4gLQo+
IC0Jd2lkdGggPSBkZXYtPm1vZGVfY29uZmlnLm1heF93aWR0aDsKPiAtCWhlaWdodCA9IGRldi0+
bW9kZV9jb25maWcubWF4X2hlaWdodDsKPiArCWlmIChkcm1fZmJfaGVscGVyX3Byb2JlX2Nvbm5l
Y3Rvcl9tb2RlcyhmYl9oZWxwZXIsIHdpZHRoLCBoZWlnaHQpID09IDApCj4gKwkJRFJNX0RFQlVH
X0tNUygiTm8gY29ubmVjdG9ycyByZXBvcnRlZCBjb25uZWN0ZWQgd2l0aCBtb2Rlc1xuIik7Cj4g
IAo+ICAJLyogcHJldmVudCBjb25jdXJyZW50IG1vZGlmaWNhdGlvbiBvZiBjb25uZWN0b3JfY291
bnQgYnkgaG90cGx1ZyAqLwo+ICAJbG9ja2RlcF9hc3NlcnRfaGVsZCgmZmJfaGVscGVyLT5kZXYt
Pm1vZGVfY29uZmlnLm11dGV4KTsKPiBAQCAtMjIzNSwyMyArMjIzNCwxNSBAQCBpbnQgZHJtX2Zi
X2hlbHBlcl9pbml0aWFsX2NvbmZpZyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLCBp
bnQgYnBwX3NlbCkKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+
ZGV2Owo+ICAJc3RydWN0IGZiX2luZm8gKmluZm87Cj4gLQlpbnQgY291bnQgPSAwOwo+ICAJaW50
IHJldDsKPiAgCj4gIAlpZiAoIWRybV9mYmRldl9lbXVsYXRpb24pCj4gIAkJcmV0dXJuIDA7Cj4g
IAo+ICAJbXV0ZXhfbG9jaygmZGV2LT5tb2RlX2NvbmZpZy5tdXRleCk7Cj4gLQljb3VudCA9IGRy
bV9mYl9oZWxwZXJfcHJvYmVfY29ubmVjdG9yX21vZGVzKGZiX2hlbHBlciwKPiAtCQkJCQkJICAg
IGRldi0+bW9kZV9jb25maWcubWF4X3dpZHRoLAo+IC0JCQkJCQkgICAgZGV2LT5tb2RlX2NvbmZp
Zy5tYXhfaGVpZ2h0KTsKPiAtCS8qCj4gLQkgKiB3ZSBzaG91bGRuJ3QgZW5kIHVwIHdpdGggbm8g
bW9kZXMgaGVyZS4KPiAtCSAqLwo+IC0JaWYgKGNvdW50ID09IDApCj4gLQkJZGV2X2luZm8oZmJf
aGVscGVyLT5kZXYtPmRldiwgIk5vIGNvbm5lY3RvcnMgcmVwb3J0ZWQgY29ubmVjdGVkIHdpdGgg
bW9kZXNcbiIpOwo+IC0KPiAtCWRybV9zZXR1cF9jcnRjcyhmYl9oZWxwZXIpOwo+ICsJZHJtX3Nl
dHVwX2NydGNzKGZiX2hlbHBlciwKPiArCQkJZGV2LT5tb2RlX2NvbmZpZy5tYXhfd2lkdGgsCj4g
KwkJCWRldi0+bW9kZV9jb25maWcubWF4X2hlaWdodCk7Cj4gIAlyZXQgPSBkcm1fZmJfaGVscGVy
X3NpbmdsZV9mYl9wcm9iZShmYl9oZWxwZXIsIGJwcF9zZWwpOwo+ICAJbXV0ZXhfdW5sb2NrKCZk
ZXYtPm1vZGVfY29uZmlnLm11dGV4KTsKPiAgCWlmIChyZXQpCj4gQEAgLTIyOTksMjggKzIyOTAs
MjIgQEAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX2luaXRpYWxfY29uZmlnKTsKPiAgaW50
IGRybV9mYl9oZWxwZXJfaG90cGx1Z19ldmVudChzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVs
cGVyKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZmJfaGVscGVyLT5kZXY7Cj4g
LQl1MzIgbWF4X3dpZHRoLCBtYXhfaGVpZ2h0Owo+ICAKPiAgCWlmICghZHJtX2ZiZGV2X2VtdWxh
dGlvbikKPiAgCQlyZXR1cm4gMDsKPiAgCj4gLQltdXRleF9sb2NrKCZmYl9oZWxwZXItPmRldi0+
bW9kZV9jb25maWcubXV0ZXgpOwo+ICsJbXV0ZXhfbG9jaygmZGV2LT5tb2RlX2NvbmZpZy5tdXRl
eCk7Cj4gIAlpZiAoIWZiX2hlbHBlci0+ZmIgfHwgIWRybV9mYl9oZWxwZXJfaXNfYm91bmQoZmJf
aGVscGVyKSkgewo+ICAJCWZiX2hlbHBlci0+ZGVsYXllZF9ob3RwbHVnID0gdHJ1ZTsKPiAtCQlt
dXRleF91bmxvY2soJmZiX2hlbHBlci0+ZGV2LT5tb2RlX2NvbmZpZy5tdXRleCk7Cj4gKwkJbXV0
ZXhfdW5sb2NrKCZkZXYtPm1vZGVfY29uZmlnLm11dGV4KTsKPiAgCQlyZXR1cm4gMDsKPiAgCX0K
PiAgCURSTV9ERUJVR19LTVMoIlxuIik7Cj4gIAo+IC0JbWF4X3dpZHRoID0gZmJfaGVscGVyLT5m
Yi0+d2lkdGg7Cj4gLQltYXhfaGVpZ2h0ID0gZmJfaGVscGVyLT5mYi0+aGVpZ2h0Owo+ICsJZHJt
X3NldHVwX2NydGNzKGZiX2hlbHBlciwgZmJfaGVscGVyLT5mYi0+d2lkdGgsIGZiX2hlbHBlci0+
ZmItPmhlaWdodCk7Cj4gIAo+IC0JZHJtX2ZiX2hlbHBlcl9wcm9iZV9jb25uZWN0b3JfbW9kZXMo
ZmJfaGVscGVyLCBtYXhfd2lkdGgsIG1heF9oZWlnaHQpOwo+IC0JbXV0ZXhfdW5sb2NrKCZmYl9o
ZWxwZXItPmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+ICsJbXV0ZXhfdW5sb2NrKCZkZXYtPm1v
ZGVfY29uZmlnLm11dGV4KTsKPiAgCj4gLQlkcm1fbW9kZXNldF9sb2NrX2FsbChkZXYpOwo+IC0J
ZHJtX3NldHVwX2NydGNzKGZiX2hlbHBlcik7Cj4gLQlkcm1fbW9kZXNldF91bmxvY2tfYWxsKGRl
dik7Cj4gIAlkcm1fZmJfaGVscGVyX3NldF9wYXIoZmJfaGVscGVyLT5mYmRldik7Cj4gIAo+ICAJ
cmV0dXJuIDA7Cj4gLS0gCj4gMi4xMC4yCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVs
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h
aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp
bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz
dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0
b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==