From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs
Date: Mon, 28 Nov 2016 14:59:30 +0000 [thread overview]
Message-ID: <20161128145930.GB18830@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20161128072607.66xcjy6kxzn7gwvi@phenom.ffwll.local>
On Mon, Nov 28, 2016 at 08:26:07AM +0100, Daniel Vetter wrote:
> On Wed, Nov 23, 2016 at 02:04:15PM +0000, Chris Wilson wrote:
> > +#define drm_fb_helper_for_each_connector(fbh, i__) \
> > + for (({lockdep_assert_held(&(fbh)->dev->mode_config.mutex); 1;}), \
> > + i__ = 0; i__ < (fbh)->connector_count; i__++)
> > +
>
> +1 on Jani's question.
I'm missing the question. Found it under pw
" No comments on the substance, but just curious, why is that "1;"
required there? Or is it?"
Hmm, the 1; itself isn't required. I was just uncomfortable when
thinking that ({}) evaluated to the result of the last statement, and
didn't want to contemplate what if that last statement was not valid in
that context. Appears gcc is quite happy since it is discarded and not
used as a rhs.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-11-28 14:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 14:04 [PATCH 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs Chris Wilson
2016-11-23 14:04 ` [PATCH 2/3] drm: Pull together probe + setup for drm_fb_helper Chris Wilson
2016-11-28 7:55 ` Daniel Vetter
2016-11-23 14:04 ` [PATCH 3/3] drm: Protect fb_helper list manipulation with a mutex Chris Wilson
2016-11-28 7:55 ` Daniel Vetter
2016-11-28 8:38 ` Chris Wilson
2016-11-28 14:16 ` Daniel Vetter
2016-11-23 14:22 ` [PATCH 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs Jani Nikula
2016-11-23 15:47 ` ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2016-11-28 7:26 ` [PATCH 1/3] " Daniel Vetter
2016-11-28 14:59 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128145930.GB18830@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.