From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756172AbcK2HuB (ORCPT ); Tue, 29 Nov 2016 02:50:01 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:49041 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755762AbcK2Htw (ORCPT ); Tue, 29 Nov 2016 02:49:52 -0500 Date: Tue, 29 Nov 2016 08:49:49 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Martin Kaiser Cc: Sascha Hauer , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: imxfb: remove the macros for initializing the DMACR Message-ID: <20161129074949.taj5bwnhge37pi5e@pengutronix.de> References: <20161125084303.GA14156@botnar.kaiser.cx> <1480372989-6413-1-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1480372989-6413-1-git-send-email-martin@kaiser.cx> User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2016 at 11:43:09PM +0100, Martin Kaiser wrote: > The current definitions of DMACR_HM() and DMACR_TM() are correct only > for imx1, they're wrong for imx21. > > The macros are meant for legacy board files only, they're not applicable > for boards using device tree. > > At the moment, there are no boards are using the macros. So it should be s/are using the/using these/ > safe to drop them rather than making them work for both imx1 and imx21, > which would require a change in the platform data struct. > > Signed-off-by: Martin Kaiser Acked-by: Uwe Kleine-König Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Date: Tue, 29 Nov 2016 07:49:49 +0000 Subject: Re: [PATCH] video: imxfb: remove the macros for initializing the DMACR Message-Id: <20161129074949.taj5bwnhge37pi5e@pengutronix.de> List-Id: References: <20161125084303.GA14156@botnar.kaiser.cx> <1480372989-6413-1-git-send-email-martin@kaiser.cx> In-Reply-To: <1480372989-6413-1-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Martin Kaiser Cc: Sascha Hauer , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Nov 28, 2016 at 11:43:09PM +0100, Martin Kaiser wrote: > The current definitions of DMACR_HM() and DMACR_TM() are correct only > for imx1, they're wrong for imx21. >=20 > The macros are meant for legacy board files only, they're not applicable > for boards using device tree. >=20 > At the moment, there are no boards are using the macros. So it should be s/are using the/using these/ > safe to drop them rather than making them work for both imx1 and imx21, > which would require a change in the platform data struct. >=20 > Signed-off-by: Martin Kaiser Acked-by: Uwe Kleine-K=F6nig Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ |