From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756309AbcK2JNO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 Nov 2016 04:13:14 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:36448 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754367AbcK2JND (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Nov 2016 04:13:03 -0500
Date: Tue, 29 Nov 2016 10:12:58 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: John Stultz <john.stultz@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Richard Cochran <richardcochran@gmail.com>,
        Prarit Bhargava <prarit@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 4/7] time: alarmtimer: Add the tracepoints for alarmtimer
Message-ID: <20161129091258.GA19534@gmail.com>
References: <1480372524-15181-1-git-send-email-john.stultz@linaro.org>
 <1480372524-15181-5-git-send-email-john.stultz@linaro.org>
 <20161129072359.GC29412@gmail.com>
 <CAMz4ku+6+BweHu5m0nZXXsQznEFPQoydoKLLzBqx+uF3LLGyfw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMz4ku+6+BweHu5m0nZXXsQznEFPQoydoKLLzBqx+uF3LLGyfw@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Baolin Wang <baolin.wang@linaro.org> wrote:

> On 29 November 2016 at 15:23, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * John Stultz <john.stultz@linaro.org> wrote:
> >
> >> From: Baolin Wang <baolin.wang@linaro.org>
> >>
> >> For system debugging, we sometimes want to know who sets one
> >> alarm timer, the time of the timer, when the timer started and
> >> fired and so on. Thus adding tracepoints can help us trace the
> >> alarmtimer information.
> >
> > s/one alarm timer/an alarm timer
> >
> >> For example, when we debug the system supend/resume, if the
> >> system is always resumed by RTC alarm, we can find out which
> >> process set the alarm timer to resume system by below trace log:
> >
> > s/when we debug the system/when we debug system
> > s/supend/suspend
> > s/resume system/resume the system
> > s/by below trace log/by the trace log below
> >
> >> From the trace log, we can find out the 'Binder:3292_2' process
> >> set one alarm timer which resumes the system.
> >
> > s/set one alarm timer/set an alarm timer
> >
> >> Changes since v4:
> >>  - Initialize 'type' to -1 and rename it in alarmtimer_suspend().
> >>  - Fix typo in subject line.
> >>
> >> Changes since v3:
> >>  - Remove the "ALARM_" prefix in the string.
> >>  - Add the ACK by Steven Rostedt.
> >>
> >> Changes since v2:
> >>  - Save time as s64 type.
> >>  - Remove 'process_name' parameter and add 'now' parameter.
> >>  - Rename the trace event name.
> >>  - Remove restart trace event.
> >>  - Other optimization.
> >
> > I find it really sad that a patch that has gone through 4 iterations still has so
> > many typos and grammar errors in its changelog :-(
> 
> Really sorry for these elementary errors, I will fix these errors in
> new patch. Sorry for troubles again.

No problem - the code looks fine to me, so we can fix this when applying the 
patches.

Thanks,

	Ingo