From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933207AbcK2Jsb (ORCPT ); Tue, 29 Nov 2016 04:48:31 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36301 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbcK2JsY (ORCPT ); Tue, 29 Nov 2016 04:48:24 -0500 Date: Tue, 29 Nov 2016 10:48:19 +0100 From: Richard Cochran To: Grygorii Strashko Cc: "David S. Miller" , netdev@vger.kernel.org, Mugunthan V N , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Murali Karicheri , Wingman Kwok Subject: Re: [PATCH v2 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister Message-ID: <20161129094819.GC3110@localhost.localdomain> References: <20161128230337.6731-1-grygorii.strashko@ti.com> <20161128230337.6731-5-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161128230337.6731-5-grygorii.strashko@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2016 at 05:03:28PM -0600, Grygorii Strashko wrote: > There are two issues with TI CPTS code which are reproducible when TI > CPSW ethX device passes few up/down iterations: > - cpts refclk prepare counter continuously incremented after each > up/down iteration; > - devm_clk_get(dev, "cpts") is called many times. > > Hence, fix these issues by using clk_disable_unprepare() in > cpts_clk_release() and skipping devm_clk_get() if cpts refclk has been > acquired already. > > Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH v2 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister Date: Tue, 29 Nov 2016 10:48:19 +0100 Message-ID: <20161129094819.GC3110@localhost.localdomain> References: <20161128230337.6731-1-grygorii.strashko@ti.com> <20161128230337.6731-5-grygorii.strashko@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mugunthan V N , Sekhar Nori , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Murali Karicheri , Wingman Kwok To: Grygorii Strashko Return-path: Content-Disposition: inline In-Reply-To: <20161128230337.6731-5-grygorii.strashko-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Nov 28, 2016 at 05:03:28PM -0600, Grygorii Strashko wrote: > There are two issues with TI CPTS code which are reproducible when TI > CPSW ethX device passes few up/down iterations: > - cpts refclk prepare counter continuously incremented after each > up/down iteration; > - devm_clk_get(dev, "cpts") is called many times. > > Hence, fix these issues by using clk_disable_unprepare() in > cpts_clk_release() and skipping devm_clk_get() if cpts refclk has been > acquired already. > > Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html