From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:35539 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757110AbcK2K1U (ORCPT ); Tue, 29 Nov 2016 05:27:20 -0500 Received: by mail-wm0-f66.google.com with SMTP id a20so23540058wme.2 for ; Tue, 29 Nov 2016 02:27:19 -0800 (PST) Date: Tue, 29 Nov 2016 11:27:20 +0100 From: Daniel Vetter To: Laurent Pinchart Cc: Daniel Vetter , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 09/13] drm: Add encoder_type field to the drm_bridge structure Message-ID: <20161129102720.alacxa4bxcyyrn3j@phenom.ffwll.local> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1480410283-28698-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20161129095653.gkfavyo23ewadatx@phenom.ffwll.local> <9030087.LEDx357bJm@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9030087.LEDx357bJm@avalon> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Tue, Nov 29, 2016 at 11:58:44AM +0200, Laurent Pinchart wrote: > On Tuesday 29 Nov 2016 10:56:53 Daniel Vetter wrote: > > On Tue, Nov 29, 2016 at 11:04:39AM +0200, Laurent Pinchart wrote: > > > The drm_bridge object models on- or off-chip hardware encoders and > > > provide an abstract control API to display drivers. In order to help > > > display drivers creating the right kind of drm_encoder object, expose > > > the type of the hardware encoder associated with each bridge. > > > > > > Signed-off-by: Laurent Pinchart > > > > > > > DRM_MODE_ENCODER_BRIDGE. Problem solved, because in reality no one cares > > one iota about the encoder type. > > It's exposed to userspace though, are you 100% sure we won't break anything ? We've added DP, DSI, DPMST and DPI encoder types thus far, no one screamed. We should be fine I think. Connector types are a bit different, userspace (at least X) wants to pretty-print them for xrandr names. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 09/13] drm: Add encoder_type field to the drm_bridge structure Date: Tue, 29 Nov 2016 11:27:20 +0100 Message-ID: <20161129102720.alacxa4bxcyyrn3j@phenom.ffwll.local> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1480410283-28698-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20161129095653.gkfavyo23ewadatx@phenom.ffwll.local> <9030087.LEDx357bJm@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B27D6E043 for ; Tue, 29 Nov 2016 10:27:20 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id g23so23549196wme.1 for ; Tue, 29 Nov 2016 02:27:19 -0800 (PST) Content-Disposition: inline In-Reply-To: <9030087.LEDx357bJm@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMjksIDIwMTYgYXQgMTE6NTg6NDRBTSArMDIwMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBPbiBUdWVzZGF5IDI5IE5vdiAyMDE2IDEwOjU2OjUzIERhbmllbCBWZXR0ZXIg d3JvdGU6Cj4gPiBPbiBUdWUsIE5vdiAyOSwgMjAxNiBhdCAxMTowNDozOUFNICswMjAwLCBMYXVy ZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gPiBUaGUgZHJtX2JyaWRnZSBvYmplY3QgbW9kZWxzIG9u LSBvciBvZmYtY2hpcCBoYXJkd2FyZSBlbmNvZGVycyBhbmQKPiA+ID4gcHJvdmlkZSBhbiBhYnN0 cmFjdCBjb250cm9sIEFQSSB0byBkaXNwbGF5IGRyaXZlcnMuIEluIG9yZGVyIHRvIGhlbHAKPiA+ ID4gZGlzcGxheSBkcml2ZXJzIGNyZWF0aW5nIHRoZSByaWdodCBraW5kIG9mIGRybV9lbmNvZGVy IG9iamVjdCwgZXhwb3NlCj4gPiA+IHRoZSB0eXBlIG9mIHRoZSBoYXJkd2FyZSBlbmNvZGVyIGFz c29jaWF0ZWQgd2l0aCBlYWNoIGJyaWRnZS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IExh dXJlbnQgUGluY2hhcnQKPiA+ID4gPGxhdXJlbnQucGluY2hhcnQrcmVuZXNhc0BpZGVhc29uYm9h cmQuY29tPgo+ID4gCj4gPiBEUk1fTU9ERV9FTkNPREVSX0JSSURHRS4gUHJvYmxlbSBzb2x2ZWQs IGJlY2F1c2UgaW4gcmVhbGl0eSBubyBvbmUgY2FyZXMKPiA+IG9uZSBpb3RhIGFib3V0IHRoZSBl bmNvZGVyIHR5cGUuCj4gCj4gSXQncyBleHBvc2VkIHRvIHVzZXJzcGFjZSB0aG91Z2gsIGFyZSB5 b3UgMTAwJSBzdXJlIHdlIHdvbid0IGJyZWFrIGFueXRoaW5nID8KCldlJ3ZlIGFkZGVkIERQLCBE U0ksIERQTVNUIGFuZCBEUEkgZW5jb2RlciB0eXBlcyB0aHVzIGZhciwgbm8gb25lCnNjcmVhbWVk LiBXZSBzaG91bGQgYmUgZmluZSBJIHRoaW5rLiBDb25uZWN0b3IgdHlwZXMgYXJlIGEgYml0IGRp ZmZlcmVudCwKdXNlcnNwYWNlIChhdCBsZWFzdCBYKSB3YW50cyB0byBwcmV0dHktcHJpbnQgdGhl bSBmb3IgeHJhbmRyIG5hbWVzLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK