From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759310AbcLAQCO (ORCPT ); Thu, 1 Dec 2016 11:02:14 -0500 Received: from mail-bn3nam01on0084.outbound.protection.outlook.com ([104.47.33.84]:64480 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750708AbcLAQCM (ORCPT ); Thu, 1 Dec 2016 11:02:12 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yazen.Ghannam@amd.com; Date: Thu, 1 Dec 2016 11:02:04 -0500 From: Yazen Ghannam To: Mauro Carvalho Chehab CC: Borislav Petkov , Stephen Rothwell , , Subject: Re: linux-next: manual merge of the edac-amd tree with the edac tree Message-ID: <20161201160203.hhm6w3iyrnvcukzu@yaz-fedora.dyhomenet> References: <20161128143726.7fda1849@canb.auug.org.au> <20161128082734.bdl4dhothemm7ja5@pd.tnic> <20161130085013.4798b4a7@vento.lan> <20161201104846.kjvuy5tj475oxzke@pd.tnic> <20161201100617.511d8aae@vento.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161201100617.511d8aae@vento.lan> User-Agent: NeoMutt/20161126 (1.7.1) X-Originating-IP: [73.35.89.163] X-ClientProxiedBy: CY1PR14CA0012.namprd14.prod.outlook.com (10.163.13.150) To DM5PR12MB1386.namprd12.prod.outlook.com (10.168.238.137) X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;2:D8TFbc9ATutI2iiItrvSjrWjgIceY2wJ26KSdHb2ULZ9vVO/nJjTAqZGrF/+kas1VR3AmWveAV18ryYesKjOVMAPcYUsWQ2LHHePBj+fsTTg+WBfnfTmSG0L9q82JzkVp433vEDBlKckX3jHU+6/qSTLP2gPAvfd8EINAVdJvr8=;3:+GwB+F7v6/8k/tPtWrQxS/8GwTQFQIkgaH9mq7upJQS6MBKJxARC+vJV4Qpe7BFNLcBpzBnhKxit//C0W608E5kUCfWWnuwDpSlw0xxylWN4RvbfOuMbFaXc2YFxseIInCWvCkGbGRUSN/oTAt5n8q9cwnPVM7t74wIgy0qiYys=;25:H/TbFfh4Qmh9U0z54Sg285KlgrnhJNxnNY6xeUNJ4klm0JJ/NJb1YV7oI8BWg0QRLwzHh+yQSp9fQK83+vFp9rYrzYhG3VjB0paLoKsh9IP2ddDuE/B6+Z1QWPn/wRWLhLIGI0Wfs4MnlA302botzZidPmK44K9aoZd45lym2l1ysT41TUIDiOfv5niEnZiTLTRRU/ObF+xhdyr+1ihuXHanUXHS7kdzHc06Jcsl9ha8D904k7o00Y2Dv6qW8N04COXDqusOCV80JNdtJDuk0YrWizqoIaBplJUKdzz+a3DcJ3wHtTDev5CH/yvm8CAEgqakMqygTY9kxEJdJi9y4OAIKq3hfgMBFTZYc82FvmW7Vq2Gu/q7OOxIlVq3luAzP1wVYjSeEYldOgWRdvZEN9t7ihh/8dojygsw75PT9wllQuc7aI9pPo0uUvIDF/9ezsctR7AgZXUzzDSdrdVCKQ== X-MS-Office365-Filtering-Correlation-Id: e887203f-0c3d-4a00-f78b-08d41a036882 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR12MB1386; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;31:Oib0zTjK1ZAYVirXfceyVgQCWl7vsim0EOW4TP7XiJHyd7iGnW2nE5Crm9L8o2QsFHkXDlItNJeqQgoaxMjHNaNg/y2bocKrlqAEhhyVfJjR2WCE7Lojg1g+rY3GdCFesr3zFAk8PsYjLyyM1rNZJZGCSRVUOvBPobimwe3rbTiJSRbr0pbqUM1G29QZoJLvUWekXbozis3Y4eO09msiizBYVhPMYFcrb07L/gAx3PZ52ceCDAyojlCxfzGYRgqRxqey8hSVL2zSHusTnxCu3SMEfyVuZaW4SRrccaOs6Pc=;20:bTfAn4qlXTcuQPlLaGQcM5hFNS5/Fbw4vYUuKwxmpdl/bKy1vtw6E7db6cFi5PmIRuBknDZ9sCRq+wtjXDAzlIFuVMpcGDWRsfcVQz7UvtzuPFH/mxygh7CJaJs/ENRMHqSKxsAY1bRunj+63evOBu4JP9BT3VKLm1yC3Gq+5F1c4Go4TPuOTtt6FEiwBY1zLN5lhrgTsiUisC3FEEQALz8GSngIQRlfbENAz8UUx4iNiKi3fD7Fr+FhUIlCvmb8Mp2i3J5xuVkqDJClQBroz1xCL0G90PfxT03Q1A5mF7qDddObS4CDFFEMsb7tGt+iA7R9vftol0E2MFIDmmchumelp/yiEG2aCIauFUCOFBZrn/PFBskk0djaHpeXVK1/giZOaIgLCsL/hjx6vynG/qvXp38MWnvbwTBaE/BQ3fWA7tG53wSWsfSuS2/XKYU8hJeOsJKWmmxVkI8zkWHWQUd9elgn3q1JtVFUSCUDhkpxiHoCa4nW7UIFibm7FzAZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110)(42068640409301); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123558021)(20161123564025)(20161123562025)(20161123555025)(20161123560025);SRVR:DM5PR12MB1386;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1386; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;4:UblYMu8TCEaHiA7bWn79LUqGPBf715bmVz8Ze6hga5yDl/2yWyWbdwWrZmA5AZCBnJJHmbook6ddnGTQ9h9UKQ7evctClkvJSJlJyymXSd6tHEib9wgCQPFP6SmGWJicHZ6A7iyAH5bTKmnf105bhmBXumjxaLzJEm1mfRiLBkrpuUzHgcuC6KTDARmSAo7yC7O5+j7YMKdzjDec3NcQ450xQ3b8Q9+WYGRh7+bb2RxEpXT+y8M0ag2plzhqu/g4MGRV3movNRNSiTsoR5n0l1pDLMFL5CNCrsBb0d+bSmPO1mcyqG9UpTAt67jD/5ecUUjdECm06Vnfk0xA7qPuUbTzcCCP3DKOoh49jps4FdEM5EF/2w08MX0z8kleXx+voSu1dTlnGjUz4dhK9dpzKnRM9kMN3cR3ZheaGd0UCjpeE2DYNnTEiPYE1V1MzHqQ/iOVFlUyKGL/7vhYipbyyU+QUZ4tK5WsDI0K4kvnNSzxalVWlPyXUV97upCybCVOvNauyiBYVfayo+qaU4s0mBITve0ned5V2rn3GesMJL+stlZRrFtaj2xVZgOUeVRC6fYZP2/ca33tCm96Nel5IIv6XQRtONk7qAoHq4o3CrkeBnB6Au38/j/J9PBILffi+MhWWTu1aFXdjJVGHueUDHYLdECaHyEcJxdg6hZVHL7qF9Tts+5OSk3ZTfsg9Pv3FhyTDhq7uoKst0B0AeFGYQ== X-Forefront-PRVS: 014304E855 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(24454002)(47776003)(7736002)(39410400001)(66066001)(6916009)(93886004)(4001350100001)(97756001)(97736004)(305945005)(7846002)(54356999)(50986999)(2950100002)(229853002)(106356001)(101416001)(1076002)(76176999)(4326007)(39450400002)(6666003)(733004)(92566002)(23726003)(81166006)(8676002)(105586002)(81156014)(2906002)(110136003)(42186005)(6116002)(3846002)(33646002)(9686002)(86362001)(50466002)(38730400001)(189998001)(5660300001)(83506001)(68736007)(46406003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1386;H:yaz-fedora.dyhomenet;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR12MB1386;23:QHv4aJlrp7mHVw8kRcS593TY5Hr0vg+lEIeUVDkKA?= =?us-ascii?Q?WBpqKnlCw6Rh8B4nstVtPlI9QNgthCr7yI+lMI39F85Xszcllk2brfQST+m6?= =?us-ascii?Q?kq15q1Ei+eoOf5k2gRAiiaBXv5ZAoWK7T1Qss2LntDXhvf88GHUDtniEIxYf?= =?us-ascii?Q?NKzvthcIEXVnKtiHZp+LKTQoy3Ea+N6tj+OuJyd8C4BuiwzZ2fuD1cij71ai?= =?us-ascii?Q?DMKBAyeG+qVjDDBtRnKSFitEV9xLoscEtzUbSj04H9t5xKIq6Txzpi3GQ8yr?= =?us-ascii?Q?d0Q87zHizaRO6tjQDFJWwLVrC90SmomiZwBYlBbz7WZNHtSuu6tStvhNO/Lf?= =?us-ascii?Q?smYiPyikX5a3F8e4w6/p+KK6puEbY2kejwYGHO7k8T1csaFf4Z9qjXzCU5eS?= =?us-ascii?Q?K3ppCPqC80Zn5FNTjSyVu2I+vlbfrobZIIOv/g/mOCb7c2r7fi6QUyFX/KnN?= =?us-ascii?Q?/hn5U870FNddpnGn67TXwH3baQ0F/ozFO6kH1sfD83idIO0i07BXSUYtvMjP?= =?us-ascii?Q?4/7DXhr5VfW5u5Pa4fscmgih0O05NTREA3T01aLMU02S9dR69KyhnRk4ZV7o?= =?us-ascii?Q?OsW//WMgx4uiPfME7QK9Cu+6m7LzRe6xY973BgEAKJcTzU1gucYSuhdF41zE?= =?us-ascii?Q?HtESJDWR2V1L/PB532NPq2qTlWtCqHBzcrCXjCflTpodTyvTf8G3PXzdUCtP?= =?us-ascii?Q?NcYlP7sjHFK+liEpqixdtm3uYL2FLsB7Jy5idsnvTBr9IifwCPHh4rdARtpC?= =?us-ascii?Q?MhY9KB1njnbf2UQCzMxVgCa1qD1nLluw18/LJ9MA/bcJoREfAkw2UVlv4rWY?= =?us-ascii?Q?yUg68IgtSK2Mjpnejwb/Li9kNoEnOYIY9S6y6KutG5M89/YzUkWWXMAPEuQe?= =?us-ascii?Q?Nblh6D5pgfWiEKOuQrNJ9cmnkA3Db+AVuTYbUIu2C3xZuo2++QIWf9haSK+4?= =?us-ascii?Q?spl5OalXXvr/esNhSpeeHbp5WbwyPoirF+zRwkAGXtjlUt0LPQ5QVF57d507?= =?us-ascii?Q?llxbfwAUQW8nQZaX65SmQBAxTi6cTzSVVcb10bt06FDGdf7JJxL1IWipFNSb?= =?us-ascii?Q?xopXjK0m/7DDhp4mIqe2iL2NE9BdzvUKcQB0ydSA9Vl5q+1dyWC/6zYGU2ND?= =?us-ascii?Q?DVfYB+URTiNtdwibKFu0tHYQB95KGimz1KFmI3mLaQQrZQqmCZkrelAz3QDr?= =?us-ascii?Q?G5yhzc1VcqyogJ821idgUBa1jmDC7JsPO7TMX2Xc7G1WQC9vyy/pr800AcjZ?= =?us-ascii?Q?/u6yx2T78A0JV9/82E=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;6:FEnecbu6q2sQ7jfJxfgnNmACvt0WP9v8rW/0lYllfs1szU1Bsk3vSIeCAAMCt3mPAgMlSJT0lOZvYj1Sbl//A9W50N+5hlWq+GWyPyCRq7RQj1pktjgegoFCpACNLquRGptLzmufmvNrn0IGTTIGSu7wLP+1DGQDLwwVHuXz6hQoNlT7q8opt451MFbmvFd3DvNkUtV6iohGYYnZeUvt0eSJcwCxeQSjfB4zsWpGbLxzhtWN9DDuTJvEcUVEbvkLfF1gDbwhrHmxd+8YJfuNUt0T7YA77xsj1zXmUYy9LwZyQW/WZ1BXlKxw3tcFeynTacK0GDQfVjzwPpUFa50htVJih+WV6GLKu8HfB9ZJ0TU=;5:K4j1loWQUpJa/TVYkR8JSokEnfyamdH3UNoi8TdG42hhSpXmO2Za/zq7AHWFZNkpFoeOIUU+Zp2wwCJIDVoe6OiarW4itZhYjj1qqUdHW7QrN1SOpEctQR2lOoxlhS3een6EOJ4OHS8BbZfBKqbnyg==;24:zdJIs9tMdJueztWybEqtW0z30lVhtlUri2U7I0U15WqI6DOt5IvcUGCn1ixWOAzyYS/SfkG2mFCt7W9jx88M01A93SrrJGU53NdDWgksBAo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;7:S3/rvdKOnrrA4iEj01+1aPJfSNiUSE1B8omIPTQLEr4zL7/7E9JndvD9nZBA3mJycIuJ4nr6mqsD/hlMX0NTlMaqdqhAgQXRdzfbaOig26f+PK5MHVk4CxzIuuTQwXp9efg86C/q6+fTNy/juUIW3Agcoi1i7MWWFPLm3245ZGmxy2grbOIr2Zpl6KusRmcewySVwtDRn6FYrlJwiL7RheFwJDlp6M5lJucW07BbdHwIA9TLkxUImmegtAXgMnWbL+UI/h9VUqAqkrJDqwLJv9rM+Mnn9rD+WKkMiwMdPj90fHqnF4PLsn+uHQoS2vRhzc+5saOra3nIW7Yh2RyifPanBWd7MX+22sXgzVvm//Q=;20:QiSuVEZIwKxUwmMg9GWFycO1VPi2b5/X0gsRSoRIzYDYGLOACTJeJbLdxCvBZSpxpC3vO3gVefmcwZI3BiYqhvDRFtg32VFUeU9YLU7VVnA7yoGacCH4qPncBDjk7XLADVYwzcf8wqGzV1DdCmqat6LmO1OggU+6HVeiySlx86rR1WnSUYQpdQRHhR26CFLDRca+bfAshsENN16bLa7bO5m9oICYKeN26yyq6BUe6xa0EIW8aeyOlmXtdNpzLWrc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2016 16:02:09.7802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1386 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 01, 2016 at 10:06:17AM -0200, Mauro Carvalho Chehab wrote: > > However, rebasing over your tree showed a new documentation gap: > ./include/linux/edac.h:144: warning: Enum value 'HW_EVENT_ERR_DEFERRED' not described in enum 'hw_event_mc_err_type' > > With was introduced by this commit: > > commit d12a969ebbfcfc25853c4147d42b388f758e8784 > Author: Yazen Ghannam > Date: Thu Nov 17 17:57:32 2016 -0500 > > EDAC, amd64: Add Deferred Error type > > Currently, deferred errors are classified as correctable in EDAC. Add a > new error type for deferred errors so that they are correctly reported > to the user. > > Signed-off-by: Yazen Ghannam > Cc: Aravind Gopalakrishnan > Cc: linux-edac > Link: http://lkml.kernel.org/r/1479423463-8536-7-git-send-email-Yazen.Ghannam@amd.com > Signed-off-by: Borislav Petkov > > > Yazen introduced a "deferred error" code (whatever it means), but didn't > document what's that. Unfortunately, the patch description is also > not clear enough about what a "deferred error" means or how userspace > is supposed to handle it. > > Yazen, > > Could you please send us a patch adding a proper description for this > new error code? > Hi Mauro, A deferred error is an uncorrectable error whose handling can be deferred, i.e. it's not urgent. This affects the system behavior, but I'm now thinking that this shouldn't affect users' behavior. I think it would be simpler to just classify deferred errors as uncorrectable errors so that users treat them as such. Boris, Can we drop or revert commit d12a969ebbfc? And can we apply a fixup like this to commit 713ad54675fd? --- From: Yazen Ghannam Date: Thu, 1 Dec 2016 08:54:49 -0600 Subject: [PATCH] fixup! EDAC, amd64: Define and register UMC error decode function Signed-off-by: Yazen Ghannam --- drivers/edac/amd64_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 991b36c..245b9a0 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -2480,8 +2480,9 @@ static void decode_umc_error(int node_id, struct mce *m) memset(&err, 0, sizeof(err)); + /* Log deferred errors as uncorrectable errors. */ if (m->status & MCI_STATUS_DEFERRED) - ecc_type = 3; + ecc_type = 1; err.channel = find_umc_channel(pvt, m); if (err.channel < 0) { -- 2.7.4 --- Thanks, Yazen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yazen Ghannam Subject: Re: linux-next: manual merge of the edac-amd tree with the edac tree Date: Thu, 1 Dec 2016 11:02:04 -0500 Message-ID: <20161201160203.hhm6w3iyrnvcukzu@yaz-fedora.dyhomenet> References: <20161128143726.7fda1849@canb.auug.org.au> <20161128082734.bdl4dhothemm7ja5@pd.tnic> <20161130085013.4798b4a7@vento.lan> <20161201104846.kjvuy5tj475oxzke@pd.tnic> <20161201100617.511d8aae@vento.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20161201100617.511d8aae@vento.lan> Sender: linux-kernel-owner@vger.kernel.org To: Mauro Carvalho Chehab Cc: Borislav Petkov , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-next.vger.kernel.org On Thu, Dec 01, 2016 at 10:06:17AM -0200, Mauro Carvalho Chehab wrote: > > However, rebasing over your tree showed a new documentation gap: > ./include/linux/edac.h:144: warning: Enum value 'HW_EVENT_ERR_DEFERRED' not described in enum 'hw_event_mc_err_type' > > With was introduced by this commit: > > commit d12a969ebbfcfc25853c4147d42b388f758e8784 > Author: Yazen Ghannam > Date: Thu Nov 17 17:57:32 2016 -0500 > > EDAC, amd64: Add Deferred Error type > > Currently, deferred errors are classified as correctable in EDAC. Add a > new error type for deferred errors so that they are correctly reported > to the user. > > Signed-off-by: Yazen Ghannam > Cc: Aravind Gopalakrishnan > Cc: linux-edac > Link: http://lkml.kernel.org/r/1479423463-8536-7-git-send-email-Yazen.Ghannam@amd.com > Signed-off-by: Borislav Petkov > > > Yazen introduced a "deferred error" code (whatever it means), but didn't > document what's that. Unfortunately, the patch description is also > not clear enough about what a "deferred error" means or how userspace > is supposed to handle it. > > Yazen, > > Could you please send us a patch adding a proper description for this > new error code? > Hi Mauro, A deferred error is an uncorrectable error whose handling can be deferred, i.e. it's not urgent. This affects the system behavior, but I'm now thinking that this shouldn't affect users' behavior. I think it would be simpler to just classify deferred errors as uncorrectable errors so that users treat them as such. Boris, Can we drop or revert commit d12a969ebbfc? And can we apply a fixup like this to commit 713ad54675fd? --- From: Yazen Ghannam Date: Thu, 1 Dec 2016 08:54:49 -0600 Subject: [PATCH] fixup! EDAC, amd64: Define and register UMC error decode function Signed-off-by: Yazen Ghannam --- drivers/edac/amd64_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 991b36c..245b9a0 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -2480,8 +2480,9 @@ static void decode_umc_error(int node_id, struct mce *m) memset(&err, 0, sizeof(err)); + /* Log deferred errors as uncorrectable errors. */ if (m->status & MCI_STATUS_DEFERRED) - ecc_type = 3; + ecc_type = 1; err.channel = find_umc_channel(pvt, m); if (err.channel < 0) { -- 2.7.4 --- Thanks, Yazen