From: David Miller <davem@davemloft.net>
To: john.fastabend@gmail.com
Cc: daniel@iogearbox.net, mst@redhat.com, shm@cumulusnetworks.com,
tgraf@suug.ch, alexei.starovoitov@gmail.com,
john.r.fastabend@intel.com, netdev@vger.kernel.org,
bblanco@plumgrid.com, brouer@redhat.com
Subject: Re: [net-next PATCH v4 1/6] net: virtio dynamically disable/enable LRO
Date: Sat, 03 Dec 2016 23:01:03 -0500 (EST) [thread overview]
Message-ID: <20161203.230103.2147950370567010856.davem@davemloft.net> (raw)
In-Reply-To: <20161202204945.4331.2419.stgit@john-Precision-Tower-5810>
From: John Fastabend <john.fastabend@gmail.com>
Date: Fri, 02 Dec 2016 12:49:45 -0800
> + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS)) {
> + sg_init_one(&sg, &offloads, sizeof(uint64_t));
> + if (!virtnet_send_command(vi,
> + VIRTIO_NET_CTRL_GUEST_OFFLOADS,
> + VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET,
> + &sg)) {
> + dev_warn(&netdev->dev,
> + "Failed to set guest offloads by virtnet command.\n");
> + return -EINVAL;
> + }
> + } else if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) &&
> + !virtio_has_feature(vdev, VIRTIO_F_VERSION_1)) {
Hmmm, to me this reads as:
if (X) {
...
else if (X && ...) {
I don't see how the second basic block can ever execute. If the virtio
has the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS feature, we will execute only
the first basic block.
Maybe I misunderstand the logic for whatever reason.
next prev parent reply other threads:[~2016-12-04 4:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 20:49 [net-next PATCH v4 0/6] XDP for virtio_net John Fastabend
2016-12-02 20:49 ` [net-next PATCH v4 1/6] net: virtio dynamically disable/enable LRO John Fastabend
2016-12-04 4:01 ` David Miller [this message]
2016-12-04 5:36 ` Michael S. Tsirkin
2016-12-04 18:59 ` John Fastabend
2016-12-02 20:50 ` [net-next PATCH v4 2/6] net: xdp: add invalid buffer warning John Fastabend
2016-12-02 20:50 ` [net-next PATCH v4 3/6] virtio_net: Add XDP support John Fastabend
2016-12-02 20:50 ` [net-next PATCH v4 4/6] virtio_net: add dedicated XDP transmit queues John Fastabend
2016-12-02 20:51 ` [net-next PATCH v4 5/6] virtio_net: add XDP_TX support John Fastabend
2016-12-03 3:10 ` John Fastabend
2016-12-02 20:51 ` [net-next PATCH v4 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161203.230103.2147950370567010856.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@plumgrid.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shm@cumulusnetworks.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.