From: Alvaro G. M. <alvaro.gamez@hazent.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] libxmlrpc: bump to 1.39.11
Date: Sun, 4 Dec 2016 16:33:28 +0100 [thread overview]
Message-ID: <20161204153328.GA27936@collins.gmr.ssr.upm.es> (raw)
In-Reply-To: <20161204150600.0bfe0ead@free-electrons.com>
On Sun, Dec 04, 2016 at 03:06:00PM +0100, Thomas Petazzoni wrote:
> All of them look like this:
>
> make[3]: Entering directory `/accts/mlweber1/rc-buildroot-test/scripts/instance-1/output/build/libxmlrpc-1.39.11/lib/libutil++'
> /accts/mlweber1/rc-buildroot-test/scripts/instance-1/output/build/libxmlrpc-1.39.11/lib/libutil++/Makefile:109: depend.mk: No such file or directory
> cat /dev/null >depend.mk
> ln -s /accts/mlweber1/rc-buildroot-test/scripts/instance-1/output/build/libxmlrpc-1.39.11 srcdir
> ln -s /accts/mlweber1/rc-buildroot-test/scripts/instance-1/output/build/libxmlrpc-1.39.11 blddir
> make[3]: Leaving directory `/accts/mlweber1/rc-buildroot-test/scripts/instance-1/output/build/libxmlrpc-1.39.11/lib/libutil++'
>
> Could you have a look and provide a patch to fix this?
Hi, Thomas
I already know the cause for this and the patch is simple. However, before
sending the proposed patch as a git am commitable email, I'd like to query
about which shall be the best way to provide it.
The issue is that this version of libxmlrpc includes new subdir libutils++,
which requires c++ but without which the library can perform its function
perfectly. The way to solve this then is to patch lib/Makefile as inlined
below, making this directory compilable only if there's c++ support.
The question is: given that there is already a patch in buildroot called
0002-fix-non-cplusplus-build.patch which does exactly the same on a
different file (lib/util/Makefile), should I modify this patch to include
both changes, as the name and description of the patch is basically the
same, or should I provide another .patch file for this to include under
package/libxmlrpc?
These are the contents of proposed patch:
--- lib/Makefile 2015-12-30 05:22:14.000000000 +0100
+++ /tmp/Makefile 2016-12-04 16:26:05.006320880 +0100
@@ -9,7 +9,10 @@
# Build up SUBDIRS:
SUBDIRS =
-SUBDIRS += util libutil libutil++
+SUBDIRS += util libutil
+ifeq ($(ENABLE_CPLUSPLUS),yes)
+ SUBDIRS += libutil++
+endif
ifeq ($(ENABLE_ABYSS_SERVER),yes)
SUBDIRS += abyss
ifeq ($(ENABLE_CPLUSPLUS),yes)
Thank you!
--
Alvaro G. M.
next prev parent reply other threads:[~2016-12-04 15:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160825063044.CF4CA101E4C@stock.ovh.net>
2016-11-02 9:56 ` [Buildroot] [PATCH 1/1] Bump libxmlrpc Alvaro G. M
2016-11-02 22:26 ` Thomas Petazzoni
2016-11-03 6:13 ` Alvaro Gamez
2016-11-11 7:58 ` [Buildroot] [PATCH v2] Bump libxmlrpc to version 1.39.10 Alvaro G. M
2016-11-11 14:38 ` Thomas Petazzoni
2016-11-15 10:49 ` Alvaro Gamez
2016-11-15 10:50 ` [Buildroot] [PATCH v3 1/1] libxmlrpc: bump to 1.39.11 Alvaro G. M
2016-11-16 22:15 ` Thomas Petazzoni
2016-11-17 8:00 ` Alvaro Gamez
2016-12-04 14:06 ` Thomas Petazzoni
2016-12-04 15:33 ` Alvaro G. M. [this message]
2016-12-04 15:37 ` Thomas Petazzoni
2016-12-04 15:55 ` [Buildroot] [PATCH 1/1] libxmlrpc: fix build without C++ compiler Alvaro G. M
2016-12-04 20:49 ` Thomas Petazzoni
2016-12-04 16:18 ` [Buildroot] [PATCH v3 1/1] libxmlrpc: bump to 1.39.11 Alvaro G. M.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204153328.GA27936@collins.gmr.ssr.upm.es \
--to=alvaro.gamez@hazent.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.