From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280AbcLFL76 (ORCPT ); Tue, 6 Dec 2016 06:59:58 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:52181 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbcLFL75 (ORCPT ); Tue, 6 Dec 2016 06:59:57 -0500 Date: Tue, 6 Dec 2016 12:38:05 +0100 From: Peter Zijlstra To: kan.liang@intel.com Cc: mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, tglx@linutronix.de, namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, wangnan0@huawei.com, mark.rutland@arm.com, andi@firstfloor.org Subject: Re: [PATCH V2 03/13] perf/x86: output sampling overhead Message-ID: <20161206113805.GO3124@twins.programming.kicks-ass.net> References: <1480713561-6617-1-git-send-email-kan.liang@intel.com> <1480713561-6617-4-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480713561-6617-4-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2016 at 04:19:11PM -0500, kan.liang@intel.com wrote: > +static void > +perf_calculate_nmi_overhead(u64 time) > +{ > + struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events); > + > + cpuc->nmi_overhead.nr++; > + cpuc->nmi_overhead.time += time; > +} This function doesn't calculate anything much.