All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Zhang Rui <rui.zhang@intel.com>,
	Khiem Nguyen <khiem.nguyen.xt@renesas.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v4 5/4] thermal: rcar_gen3_thermal: restrict to 64BIT
Date: Tue, 6 Dec 2016 16:39:57 -0800	[thread overview]
Message-ID: <20161207003956.GA12562@localhost.localdomain> (raw)
In-Reply-To: <20161202204422.21832-1-wsa+renesas@sang-engineering.com>

On Fri, Dec 02, 2016 at 09:44:22PM +0100, Wolfram Sang wrote:
> COMPILE_TEST triggers problems on 32 bit machines, so limit this driver
> to 64BIT for now. This is no loss because the hardware is only available
> on 64 bit SoCs anyhow. After we obtained more data from the hardware
> engineers, we will refactor the code to be usable with COMPILE_TEST.
> 

Don't you want to fold this one into patch 2 and mention the limitation
on that patch's commit log?

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> buildbot reported the problem and seems to be happy now.
> 
>  drivers/thermal/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 3912d24a07b10f..edaed1282791bf 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -247,7 +247,7 @@ config RCAR_THERMAL
>  
>  config RCAR_GEN3_THERMAL
>  	tristate "Renesas R-Car Gen3 thermal driver"
> -	depends on ARCH_RENESAS || COMPILE_TEST
> +	depends on ARCH_RENESAS && 64BIT
>  	depends on HAS_IOMEM
>  	depends on OF
>  	help
> -- 
> 2.10.2
> 

  reply	other threads:[~2016-12-07  0:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 22:04 [PATCH v4 0/4] thermal: add driver for R-Car Gen3 Wolfram Sang
2016-12-01 22:04 ` [PATCH v4 1/4] thermal: rcar_gen3_thermal: Document the " Wolfram Sang
2016-12-01 22:04 ` [PATCH v4 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver Wolfram Sang
2016-12-07  1:01   ` Eduardo Valentin
2016-12-07  9:06     ` Wolfram Sang
2016-12-13  3:22       ` Eduardo Valentin
2016-12-07  1:15   ` Eduardo Valentin
2016-12-01 22:04 ` [PATCH v4 3/4] arm64: dts: r8a7795: Add R-Car Gen3 thermal support Wolfram Sang
2016-12-01 22:04 ` [PATCH v4 4/4] arm64: dts: r8a7796: " Wolfram Sang
2016-12-02 20:44 ` [PATCH v4 5/4] thermal: rcar_gen3_thermal: restrict to 64BIT Wolfram Sang
2016-12-07  0:39   ` Eduardo Valentin [this message]
2016-12-07  8:51     ` Wolfram Sang
2017-01-10 10:16 ` [PATCH v4 0/4] thermal: add driver for R-Car Gen3 Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161207003956.GA12562@localhost.localdomain \
    --to=edubezval@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=khiem.nguyen.xt@renesas.com \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.