From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eryu Guan <eguan@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [BUG] xfs/109 crashed 2k block size reflink enabled XFS
Date: Thu, 8 Dec 2016 06:30:39 -0800 [thread overview]
Message-ID: <20161208143039.GA32751@infradead.org> (raw)
In-Reply-To: <20161208063503.GJ8436@birch.djwong.org>
On Wed, Dec 07, 2016 at 10:35:03PM -0800, Darrick J. Wong wrote:
> I bet that assert is a result of the btree insert failing to find a new
> block to expand into. I've felt for a while that we ought to yell ENOSPC
> louder when this happens, since I've hit it numerous times and grumbled
> about it not being obvious that we ran out of space.
Heh. Took me a while to figure out what caused it last night as well.
> Anyway, XFS_AG_RESV_AGFL only gets a reservation if rmapbt=1 (or if you
> added an additional reservation after dinner), so if you're running
> reflink only then it's not surprising that it still runs out of space,
> since reflink=1 only reserves RESV_METADATA space.
I'm not running reflink only - this is the testcase from Eryu with
reflink and rmpbt for now.
But at that point I didn't add RESV_METADATA to xfs_bmbt_alloc_block.
With that one liner added xfs/109 seems to be doing fine so far, and
I've had it running for a few hours already today. Note that this
is still without actually reserving additional block in
xfs_ag_resv_init, which is probably needed.
next prev parent reply other threads:[~2016-12-08 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 9:21 [BUG] xfs/109 crashed 2k block size reflink enabled XFS Eryu Guan
2016-12-05 12:45 ` Christoph Hellwig
2016-12-05 14:39 ` Christoph Hellwig
2016-12-05 15:36 ` Christoph Hellwig
2016-12-05 18:28 ` Darrick J. Wong
2016-12-05 19:05 ` Christoph Hellwig
2016-12-06 6:37 ` Eryu Guan
2016-12-06 14:45 ` Christoph Hellwig
2016-12-06 15:19 ` Brian Foster
2016-12-06 18:14 ` Darrick J. Wong
2016-12-07 3:49 ` Darrick J. Wong
2016-12-07 7:18 ` Christoph Hellwig
2016-12-07 17:40 ` Christoph Hellwig
2016-12-08 6:35 ` Darrick J. Wong
2016-12-08 14:30 ` Christoph Hellwig [this message]
2016-12-06 13:48 ` Christoph Hellwig
2016-12-06 15:24 ` Eryu Guan
2016-12-06 16:31 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208143039.GA32751@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.