From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD Date: Thu, 8 Dec 2016 16:27:45 +0100 Message-ID: <20161208152744.GB22892@potion> References: <1480530499-19098-1-git-send-email-jmattson@google.com> <1680a2c8-f132-aaae-9435-025325488aaf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jim Mattson , kvm@vger.kernel.org, GanShun To: David Hildenbrand Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbcLHP1s (ORCPT ); Thu, 8 Dec 2016 10:27:48 -0500 Content-Disposition: inline In-Reply-To: <1680a2c8-f132-aaae-9435-025325488aaf@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-12-05 15:31+0100, David Hildenbrand: > Am 30.11.2016 um 19:28 schrieb Jim Mattson: >> From: GanShun >> >> When the operand passed to VMPTRLD matches the address of the VMXON >> region, the VMX instruction error code should be >> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER. >> >> Signed-off-by: Jim Mattson >> --- >> arch/x86/kvm/vmx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >> index 0c4cde8..a1c7a43 100644 >> --- a/arch/x86/kvm/vmx.c >> +++ b/arch/x86/kvm/vmx.c >> @@ -6960,7 +6960,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason, >> >> if (vmptr == vmx->nested.vmxon_ptr) { >> nested_vmx_failValid(vcpu, >> - VMXERR_VMCLEAR_VMXON_POINTER); >> + VMXERR_VMPTRLD_VMXON_POINTER); >> skip_emulated_instruction(vcpu); >> return 1; >> } >> > > VMXERR_VMPTRLD_VMXON_POINTER was completely unused so far. This is correct > (Vol. 3C 30-16 and 30-29). > > Reviewed-by: David Hildenbrand Jim, I don't see your emails on the list (that don't Cc me) after Nov 4. Have you posted more than this patch and the checkpoint/restore series? ([PATCH 0/8] kvm: nVMX: Checkpoint/restore support for VMX state) I'm sorry they fell through cracks. (Still no idea why -- filters don't even delete mail.)