From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/3] crypto: brcm: DT documentation for Broadcom SPU driver Date: Fri, 9 Dec 2016 15:26:18 -0600 Message-ID: <20161209212618.gvjdjhmryobrmwrp@rob-hp-laptop> References: <1480714499-1476-1-git-send-email-rob.rice@broadcom.com> <1480714499-1476-2-git-send-email-rob.rice@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Herbert Xu , "David S. Miller" , Mark Rutland , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Catalin Marinas , Will Deacon , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Steve Lin To: Rob Rice Return-path: Content-Disposition: inline In-Reply-To: <1480714499-1476-2-git-send-email-rob.rice-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Fri, Dec 02, 2016 at 04:34:57PM -0500, Rob Rice wrote: > Device tree documentation for Broadcom Secure Processing Unit > (SPU) crypto driver. > > Signed-off-by: Steve Lin > Signed-off-by: Rob Rice > --- > .../devicetree/bindings/crypto/brcm,spu-crypto.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > > diff --git a/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt b/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > new file mode 100644 > index 0000000..e5fe942 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > @@ -0,0 +1,25 @@ > +The Broadcom Secure Processing Unit (SPU) driver supports symmetric Bindings describe h/w, not drivers. > +cryptographic offload for Broadcom SoCs with SPU hardware. A SoC may have > +multiple SPU hardware blocks. > + > +Required properties: > +- compatible : Should be "brcm,spum-crypto" for devices with SPU-M hardware Additionally, you should have SoC specific compatible here. > + (e.g., Northstar2) or "brcm,spum-nsp-crypto" for the Northstar Plus variant > + of the SPU-M hardware. > + > +- reg: Should contain SPU registers location and length. > +- mboxes: A list of mailbox channels to be used by the kernel driver. Mailbox > +channels correspond to DMA rings on the device. What determines the mbox assignment? Needs to specify how many. > + > +Example: > + spu-crypto@612d0000 { Just crypto@... Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbcLIV0W (ORCPT ); Fri, 9 Dec 2016 16:26:22 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35001 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbcLIV0U (ORCPT ); Fri, 9 Dec 2016 16:26:20 -0500 Date: Fri, 9 Dec 2016 15:26:18 -0600 From: Rob Herring To: Rob Rice Cc: Herbert Xu , "David S. Miller" , Mark Rutland , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list@broadcom.com, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Steve Lin Subject: Re: [PATCH v2 1/3] crypto: brcm: DT documentation for Broadcom SPU driver Message-ID: <20161209212618.gvjdjhmryobrmwrp@rob-hp-laptop> References: <1480714499-1476-1-git-send-email-rob.rice@broadcom.com> <1480714499-1476-2-git-send-email-rob.rice@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480714499-1476-2-git-send-email-rob.rice@broadcom.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2016 at 04:34:57PM -0500, Rob Rice wrote: > Device tree documentation for Broadcom Secure Processing Unit > (SPU) crypto driver. > > Signed-off-by: Steve Lin > Signed-off-by: Rob Rice > --- > .../devicetree/bindings/crypto/brcm,spu-crypto.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > > diff --git a/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt b/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > new file mode 100644 > index 0000000..e5fe942 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > @@ -0,0 +1,25 @@ > +The Broadcom Secure Processing Unit (SPU) driver supports symmetric Bindings describe h/w, not drivers. > +cryptographic offload for Broadcom SoCs with SPU hardware. A SoC may have > +multiple SPU hardware blocks. > + > +Required properties: > +- compatible : Should be "brcm,spum-crypto" for devices with SPU-M hardware Additionally, you should have SoC specific compatible here. > + (e.g., Northstar2) or "brcm,spum-nsp-crypto" for the Northstar Plus variant > + of the SPU-M hardware. > + > +- reg: Should contain SPU registers location and length. > +- mboxes: A list of mailbox channels to be used by the kernel driver. Mailbox > +channels correspond to DMA rings on the device. What determines the mbox assignment? Needs to specify how many. > + > +Example: > + spu-crypto@612d0000 { Just crypto@... Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Fri, 9 Dec 2016 15:26:18 -0600 Subject: [PATCH v2 1/3] crypto: brcm: DT documentation for Broadcom SPU driver In-Reply-To: <1480714499-1476-2-git-send-email-rob.rice@broadcom.com> References: <1480714499-1476-1-git-send-email-rob.rice@broadcom.com> <1480714499-1476-2-git-send-email-rob.rice@broadcom.com> Message-ID: <20161209212618.gvjdjhmryobrmwrp@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Dec 02, 2016 at 04:34:57PM -0500, Rob Rice wrote: > Device tree documentation for Broadcom Secure Processing Unit > (SPU) crypto driver. > > Signed-off-by: Steve Lin > Signed-off-by: Rob Rice > --- > .../devicetree/bindings/crypto/brcm,spu-crypto.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > > diff --git a/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt b/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > new file mode 100644 > index 0000000..e5fe942 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/brcm,spu-crypto.txt > @@ -0,0 +1,25 @@ > +The Broadcom Secure Processing Unit (SPU) driver supports symmetric Bindings describe h/w, not drivers. > +cryptographic offload for Broadcom SoCs with SPU hardware. A SoC may have > +multiple SPU hardware blocks. > + > +Required properties: > +- compatible : Should be "brcm,spum-crypto" for devices with SPU-M hardware Additionally, you should have SoC specific compatible here. > + (e.g., Northstar2) or "brcm,spum-nsp-crypto" for the Northstar Plus variant > + of the SPU-M hardware. > + > +- reg: Should contain SPU registers location and length. > +- mboxes: A list of mailbox channels to be used by the kernel driver. Mailbox > +channels correspond to DMA rings on the device. What determines the mbox assignment? Needs to specify how many. > + > +Example: > + spu-crypto at 612d0000 { Just crypto at ... Rob