From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbcLJOY1 convert rfc822-to-8bit (ORCPT ); Sat, 10 Dec 2016 09:24:27 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:56523 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752323AbcLJOYZ (ORCPT ); Sat, 10 Dec 2016 09:24:25 -0500 Date: Sat, 10 Dec 2016 09:16:04 +0100 From: Pavel Machek To: Tomas Hlavacek Cc: Andrew Lunn , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Rob Herring , Mark Rutland , Russell King , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] ARM: dts: Add support for Turris Omnia Message-ID: <20161210081604.GA8273@xo-6d-61-c0.localdomain> References: <1479851991.26813.2@smtp.gmail.com> <1479859770-9375-1-git-send-email-tmshlvck@gmail.com> <20161123003505.GL2691@lunn.ch> <4e3f9628-dbf8-27c1-abea-d0ef58a67e51@kleine-koenig.org> <20161124150700.GD7155@lunn.ch> <1480078151.381.4@smtp.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1480078151.381.4@smtp.gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > >Yes. That is fine. It is just unusual. Most boards have gpio-led and > >gpio-keys, which are easy to add. That is why i asked. Adding an LED > >driver which talks to this M0 can be added later. > > Actually the WiP driver for MCU LED interface, that we use in our > kernel is here: https://github.com/tmshlvck/omnia-linux/commit/2121afd8fbd2e4c720edcdd472b11b5303bc0dfb > > It definitely needs some cleanup and it adds non-standard features > (main PWM for all LEDs, autonomous blink mode, colors) via custom > /sys files, which I suspect that is not going to be acceptable for > upstream. Let's keep it for the next iteration. Actually, LEDs that can do PWM intensity on their own are common and supported. LEDs that can do PWM pretty advanced patterns are common in the cellphones, as is the color. Unfortunately, good support in kernel is missing. It would be good to change that. In n900, I have a LED that can compute prime numbers then blink them, autonomously. We probably don't need to support _that_, but common support for patterns would be good. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC PATCH] ARM: dts: Add support for Turris Omnia Date: Sat, 10 Dec 2016 09:16:04 +0100 Message-ID: <20161210081604.GA8273@xo-6d-61-c0.localdomain> References: <1479851991.26813.2@smtp.gmail.com> <1479859770-9375-1-git-send-email-tmshlvck@gmail.com> <20161123003505.GL2691@lunn.ch> <4e3f9628-dbf8-27c1-abea-d0ef58a67e51@kleine-koenig.org> <20161124150700.GD7155@lunn.ch> <1480078151.381.4@smtp.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Return-path: Content-Disposition: inline In-Reply-To: <1480078151.381.4-TAvD023jEQEN+BqQ9rBEUg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tomas Hlavacek Cc: Andrew Lunn , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Rob Herring , Mark Rutland , Russell King , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi! > >Yes. That is fine. It is just unusual. Most boards have gpio-led and > >gpio-keys, which are easy to add. That is why i asked. Adding an LED > >driver which talks to this M0 can be added later. > > Actually the WiP driver for MCU LED interface, that we use in our > kernel is here: https://github.com/tmshlvck/omnia-linux/commit/2121afd8fbd2e4c720edcdd472b11b5303bc0dfb > > It definitely needs some cleanup and it adds non-standard features > (main PWM for all LEDs, autonomous blink mode, colors) via custom > /sys files, which I suspect that is not going to be acceptable for > upstream. Let's keep it for the next iteration. Actually, LEDs that can do PWM intensity on their own are common and supported. LEDs that can do PWM pretty advanced patterns are common in the cellphones, as is the color. Unfortunately, good support in kernel is missing. It would be good to change that. In n900, I have a LED that can compute prime numbers then blink them, autonomously. We probably don't need to support _that_, but common support for patterns would be good. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Sat, 10 Dec 2016 09:16:04 +0100 Subject: [RFC PATCH] ARM: dts: Add support for Turris Omnia In-Reply-To: <1480078151.381.4@smtp.gmail.com> References: <1479851991.26813.2@smtp.gmail.com> <1479859770-9375-1-git-send-email-tmshlvck@gmail.com> <20161123003505.GL2691@lunn.ch> <4e3f9628-dbf8-27c1-abea-d0ef58a67e51@kleine-koenig.org> <20161124150700.GD7155@lunn.ch> <1480078151.381.4@smtp.gmail.com> Message-ID: <20161210081604.GA8273@xo-6d-61-c0.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi! > >Yes. That is fine. It is just unusual. Most boards have gpio-led and > >gpio-keys, which are easy to add. That is why i asked. Adding an LED > >driver which talks to this M0 can be added later. > > Actually the WiP driver for MCU LED interface, that we use in our > kernel is here: https://github.com/tmshlvck/omnia-linux/commit/2121afd8fbd2e4c720edcdd472b11b5303bc0dfb > > It definitely needs some cleanup and it adds non-standard features > (main PWM for all LEDs, autonomous blink mode, colors) via custom > /sys files, which I suspect that is not going to be acceptable for > upstream. Let's keep it for the next iteration. Actually, LEDs that can do PWM intensity on their own are common and supported. LEDs that can do PWM pretty advanced patterns are common in the cellphones, as is the color. Unfortunately, good support in kernel is missing. It would be good to change that. In n900, I have a LED that can compute prime numbers then blink them, autonomously. We probably don't need to support _that_, but common support for patterns would be good. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html