All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: kernel@pengutronix.de, linux-kbuild@vger.kernel.org,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] make use of make variable CURDIR instead of calling pwd
Date: Sun, 11 Dec 2016 12:15:47 +0100	[thread overview]
Message-ID: <20161211111547.GD30135@sepie.suse.cz> (raw)
In-Reply-To: <20161122083026.6345-1-uwe@kleine-koenig.org>

On Tue, Nov 22, 2016 at 09:30:26AM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> make already provides the current working directory in a variable, so make
> use of it instead of forking a shell. Also replace usage of PWD by
> CURDIR. PWD is provided by most shells, but not all, so this makes the
> build system more robust.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> BTW, the comment "set up PWD so that older versions of make will work
> with our build." in tools/power/cpupower/Makefile is wrong. PWD is a
> variable provided by most modern shells, so it has nothing to do with
> old make.
> 
> I don't know where to send this patch, so I picked the kbuild entry from
> MAINTAINERS as best match. If you think there is a better alternative or
> this patch needs splitting, please tell me.

I applied it to the kbuild tree. If conflicts happen, their resolution
should be straightforward.

Michal

      reply	other threads:[~2016-12-11 11:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  8:30 [PATCH] make use of make variable CURDIR instead of calling pwd Uwe Kleine-König
2016-12-11 11:15 ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161211111547.GD30135@sepie.suse.cz \
    --to=mmarek@suse.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.