Re: [PATCH] libxl: init_acpi_config should return rc in exit path

From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] libxl: init_acpi_config should return rc in exit path
Date: Wed, 14 Dec 2016 12:28:12 +0000	[thread overview]
Message-ID: <20161214122812.GC10270@citrix.com> (raw)
In-Reply-To: <ccb3c2b4-758e-1a42-a5f3-75ba9de0bece@citrix.com>

On Wed, Dec 14, 2016 at 11:49:34AM +0000, Andrew Cooper wrote:
> On 14/12/16 11:44, Wei Liu wrote:
> > ... otherwise it returns 0 even if the function fails.
> 
> Coverity-ID: 1397121
> 

Does it work this way? Coverity does lead to the discovery of this bug,
but this CID doesn't reveal the bug directly.

> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >
> > This should be backported to 4.8.
> > ---
> >  tools/libxl/libxl_x86_acpi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/libxl/libxl_x86_acpi.c b/tools/libxl/libxl_x86_acpi.c
> > index 686ac8e..6cf0c30 100644
> > --- a/tools/libxl/libxl_x86_acpi.c
> > +++ b/tools/libxl/libxl_x86_acpi.c
> > @@ -154,7 +154,7 @@ static int init_acpi_config(libxl__gc *gc,
> >      config->acpi_revision = 5;
> >  
> >  out:
> > -    return 0;
> > +    return rc;
> >  }
> >  
> >  int libxl__dom_load_acpi(libxl__gc *gc,
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel