From: Sebastian Reichel <sre@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] power: supply: bq24735-charger: simplify register update to stop charging
Date: Wed, 14 Dec 2016 17:41:33 +0100 [thread overview]
Message-ID: <20161214164132.mxbx4tiwefbe6c2r@earth> (raw)
In-Reply-To: <1481673405-4547-2-git-send-email-peda@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
Hi,
On Wed, Dec 14, 2016 at 12:56:43AM +0100, Peter Rosin wrote:
> Providing value bits outside of the mask is pointless.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/power/supply/bq24735-charger.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c
> index eb7783b42e0a..1d5c9206e0ed 100644
> --- a/drivers/power/supply/bq24735-charger.c
> +++ b/drivers/power/supply/bq24735-charger.c
> @@ -111,8 +111,7 @@ static inline int bq24735_enable_charging(struct bq24735 *charger)
> return 0;
>
> return bq24735_update_word(charger->client, BQ24735_CHG_OPT,
> - BQ24735_CHG_OPT_CHARGE_DISABLE,
> - ~BQ24735_CHG_OPT_CHARGE_DISABLE);
> + BQ24735_CHG_OPT_CHARGE_DISABLE, 0);
> }
>
> static inline int bq24735_disable_charging(struct bq24735 *charger)
Thanks for your patch. We are currently in the merge
window and your patch will appear in linux-next once
4.10-rc1 has been tagged by Linus Torvalds.
Until then I queued it into this branch:
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next-next
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2016-12-14 16:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 23:56 [PATCH v2 0/3] bq24735-charger: allow gpio polling and sharing Peter Rosin
2016-12-13 23:56 ` [PATCH v2 1/3] power: supply: bq24735-charger: simplify register update to stop charging Peter Rosin
2016-12-14 16:41 ` Sebastian Reichel [this message]
2016-12-13 23:56 ` [PATCH v2 2/3] power: supply: bq24735-charger: optionally poll the ac-detect gpio Peter Rosin
2016-12-14 15:10 ` Sebastian Reichel
2016-12-15 9:28 ` [PATCH v3] " Peter Rosin
2016-12-15 9:28 ` Peter Rosin
2016-12-17 15:04 ` Sebastian Reichel
2016-12-17 15:04 ` Sebastian Reichel
2016-12-19 22:16 ` Rob Herring
2016-12-13 23:56 ` [PATCH v2 3/3] power: supply: bq24735-charger: allow chargers to share " Peter Rosin
2016-12-14 16:59 ` Sebastian Reichel
2016-12-14 17:01 ` Sebastian Reichel
2016-12-14 17:41 ` Peter Rosin
2016-12-14 17:41 ` Peter Rosin
2016-12-30 7:49 ` Linus Walleij
2017-01-02 8:31 ` Peter Rosin
2017-01-09 18:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214164132.mxbx4tiwefbe6c2r@earth \
--to=sre@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.