From: Kevin Wolf <kwolf@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault
Date: Thu, 15 Dec 2016 09:47:38 +0100 [thread overview]
Message-ID: <20161215084738.GA5484@noname.redhat.com> (raw)
In-Reply-To: <20161215004752-mutt-send-email-mst@kernel.org>
Am 14.12.2016 um 23:49 hat Michael S. Tsirkin geschrieben:
> On Wed, Dec 14, 2016 at 02:25:18PM +0000, Stefan Hajnoczi wrote:
> > The "Copy" menu item copies VTE terminal text to the clipboard. This
> > only works with VTE terminals, not with graphics consoles.
> >
> > Disable the menu item when the current notebook page isn't a VTE
> > terminal.
> >
> > This patch fixes a segfault. Reproducer: Start QEMU and click the Copy
> > menu item when the guest display is visible.
> >
> > Reported-by: Kevin Wolf <kwolf@redhat.com>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> I don't think it's 2.8 personally, patch just disables an
> illegal action. Similar to the hotplug crash fix I
> have queued. Just document this as a known issue.
This is an immediate crash for selecting a menu entry in the default
view (which means killing a VM accidentally), we know the patch to fix
it, and it is really small. Why would we not merge something like this?
Are we making intentionally shitty releases these days?
I don't know your hotplug problem, but if it's a crash that isn't a
real corner case, that suggests that it should have been fixed. I mean,
fixing bugs is exactly what the freeze is for.
Kevin
next prev parent reply other threads:[~2016-12-15 8:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 14:25 [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault Stefan Hajnoczi
2016-12-14 14:35 ` Stefan Weil
2016-12-14 15:15 ` Gerd Hoffmann
2016-12-14 22:49 ` Michael S. Tsirkin
2016-12-15 7:34 ` Stefan Hajnoczi
2016-12-15 7:48 ` Stefan Hajnoczi
2016-12-15 8:47 ` Kevin Wolf [this message]
2016-12-15 9:50 ` Stefan Hajnoczi
2016-12-15 4:35 ` [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode Michael S. Tsirkin
2016-12-15 7:50 ` Stefan Hajnoczi
2016-12-15 9:17 ` Gerd Hoffmann
2016-12-15 14:55 ` Michael S. Tsirkin
2016-12-15 16:17 ` Gerd Hoffmann
2016-12-15 15:07 ` Michael S. Tsirkin
2016-12-15 16:25 ` Gerd Hoffmann
2016-12-15 19:15 ` Michael S. Tsirkin
2016-12-15 19:19 ` Michael S. Tsirkin
2016-12-16 8:26 ` Thomas Huth
2016-12-16 8:45 ` Liviu Ionescu
2016-12-16 9:00 ` Kevin Wolf
2016-12-16 9:21 ` Howard Spoelstra
2016-12-16 9:48 ` Gerd Hoffmann
2016-12-15 22:30 ` Michael S. Tsirkin
2016-12-16 9:27 ` Kevin Wolf
2016-12-16 9:36 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215084738.GA5484@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.