From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757505AbcLOIvp (ORCPT ); Thu, 15 Dec 2016 03:51:45 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:48598 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528AbcLOIvo (ORCPT ); Thu, 15 Dec 2016 03:51:44 -0500 Date: Thu, 15 Dec 2016 00:51:41 -0800 From: Christoph Hellwig To: "Jason A. Donenfeld" Cc: Dave Airlie , linux-kernel@vger.kernel.org, Thomas Hellstrom Subject: Re: [PATCH] kref: prefer atomic_inc_not_zero to atomic_add_unless Message-ID: <20161215085141.GA25906@infradead.org> References: <561ABFA6.8050102@vmware.com> <20161215045810.3065-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161215045810.3065-1-Jason@zx2c4.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's also way easier to read using atomic_inc_not_zero.. Reviewed-by: Christoph Hellwig Not sure you're sending this to the right maintainers, though. You probably want to include Greg.