From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vishwanathapura, Niranjana" Subject: Re: [RFC v2 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface Date: Thu, 15 Dec 2016 00:53:49 -0800 Message-ID: <20161215085349.GA90068@knc-06.sc.intel.com> References: <1481788782-89964-1-git-send-email-niranjana.vishwanathapura@intel.com> <1481788782-89964-3-git-send-email-niranjana.vishwanathapura@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <1481788782-89964-3-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Dec 14, 2016 at 11:59:34PM -0800, Vishwanathapura, Niranjana wrote: >+ >+static inline bool is_hfi_ibdev(struct ib_device *ibdev) >+{ >+ return !memcmp(ibdev->name, "hfi", 3); >+} I am thinking of adding a device capability flag to indicate HFI VNIC capabilty instead of relying on the device name as above to identify a hfi ib deice. Any comments? Probably it can be addressed by a separate patch later. Niranjana > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html