From: Andi Shyti <andi@etezian.org>
To: Sean Young <sean@mess.org>
Cc: Andi Shyti <andi.shyti@samsung.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions
Date: Fri, 16 Dec 2016 01:01:18 +0900 [thread overview]
Message-ID: <20161215160118.77hz5kuqjmxuotry@jack.zhora.eu> (raw)
In-Reply-To: <20161215155049.GA23320@gofer.mess.org>
> > + /* rc_open will be called here */
> > + rc = input_register_device(dev->input_dev);
> > + if (rc)
> > + goto out_table;
> > +
> > + dev->input_dev->dev.parent = &dev->dev;
> > + memcpy(&dev->input_dev->id, &dev->input_id, sizeof(dev->input_id));
> > + dev->input_dev->phys = dev->input_phys;
> > + dev->input_dev->name = dev->input_name;
>
> I was testing your changes, and with this patch none of my rc devices
> have input devices associated with them. The problem is that you've changed
> the order: input_register_device() should happen AFTER the preceding
> 4 lines.
This must have been a copy paste error and I don't have
transmitters to test it. Thanks for testing it. I will send it
again.
Andi
next prev parent reply other threads:[~2016-12-15 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 14:00 [PATCH v4 0/6] Add support for IR transmitters Andi Shyti
2016-12-14 14:00 ` Andi Shyti
2016-12-14 14:00 ` [PATCH v4 1/6] [media] rc-main: assign driver type during allocation Andi Shyti
2016-12-14 14:00 ` [PATCH v4 2/6] [media] rc-main: split setup and unregister functions Andi Shyti
2016-12-15 15:50 ` Sean Young
2016-12-15 16:01 ` Andi Shyti [this message]
2016-12-14 14:00 ` [PATCH v4 3/6] [media] rc-core: add support for IR raw transmitters Andi Shyti
2016-12-14 14:00 ` [PATCH v4 4/6] [media] rc-ir-raw: do not generate any receiving thread for " Andi Shyti
2016-12-14 14:00 ` [PATCH v4 5/6] Documentation: bindings: add documentation for ir-spi device driver Andi Shyti
2016-12-14 14:00 ` [PATCH v4 6/6] [media] rc: add support for IR LEDs driven through SPI Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215160118.77hz5kuqjmxuotry@jack.zhora.eu \
--to=andi@etezian.org \
--cc=andi.shyti@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.