From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425AbcLORSA (ORCPT ); Thu, 15 Dec 2016 12:18:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:48211 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbcLORR7 (ORCPT ); Thu, 15 Dec 2016 12:17:59 -0500 Date: Thu, 15 Dec 2016 18:17:55 +0100 From: Borislav Petkov To: Boris Ostrovsky Cc: Juergen Gross , Linux Kernel Mailing List , xen-devel Subject: Re: Can't boot as Xen dom0 due to commit fe055896 Message-ID: <20161215171755.xpfuax7a6q3jofet@pd.tnic> References: <73a4d64b-b139-6579-a560-92311641d6c7@suse.com> <20161215164635.thm7ruio2ddnxszw@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2016 at 12:00:22PM -0500, Boris Ostrovsky wrote: > There is an error on AMD as well. We end up being called at > load_microcode_amd() with size=0 and crash soon after. Does that fix it? diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index dd47e60aabf5..e238119b5dff 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1202,6 +1202,7 @@ config X86_REBOOTFIXUPS config MICROCODE bool "CPU microcode loading support" default y + depends on !XEN depends on CPU_SUP_AMD || CPU_SUP_INTEL select FW_LOADER ---help--- > (As a side note, I think verify_and_add_patch() should return error > codes and not crnt_size, which may be a positive number. Which it was in > my case.) It does return negative values when there's some failure. It returns crnt_size which can be a positive number so that we can advance to the next patch in the blob. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --