From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, eguan@redhat.com,
darrick.wong@oracle.com
Subject: Re: [PATCH 1/4] xfs: fix bogus minleft manipulations
Date: Fri, 16 Dec 2016 09:20:44 +0100 [thread overview]
Message-ID: <20161216082044.GB32288@lst.de> (raw)
In-Reply-To: <20161215220938.GV4219@dastard>
On Fri, Dec 16, 2016 at 09:09:38AM +1100, Dave Chinner wrote:
> > @@ -3812,7 +3812,6 @@ xfs_bmap_btalloc(
> > args.fsbno = 0;
> > args.type = XFS_ALLOCTYPE_FIRST_AG;
> > args.total = ap->minlen;
> > - args.minleft = 0;
> > if ((error = xfs_alloc_vextent(&args)))
> > return error;
> > ap->dfops->dop_low = true;
>
> But this looks wrong. when combined with the next patch that sets:
>
> args.minleft = xfs_bmap_worst_indlen(ap->ip, args.maxlen);
>
> we've got a minleft value that might be for multigigabyte
> allocation, but now we are only asking for a total allocation
> of minlen, and that might be 1 block. IOWs, shouldn't this "last,
> final attempt" code actually do something like this:
>
> args.maxlen = ap->minlen;
> args.total = ap->minlen;
> args.minleft = xfs_bmap_worst_indlen(ap->ip, args.maxlen);
Yes. And I actually had that in a previous iteration, and it got
dropped at some point.
next prev parent reply other threads:[~2016-12-16 8:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 15:59 minleft fixes Christoph Hellwig
2016-12-13 15:59 ` [PATCH 1/4] xfs: fix bogus minleft manipulations Christoph Hellwig
2016-12-14 17:35 ` Brian Foster
2016-12-14 19:36 ` Christoph Hellwig
2016-12-14 21:51 ` Brian Foster
[not found] ` <20161215143430.GB29477@bfoster.bfoster>
2016-12-16 8:21 ` Christoph Hellwig
2016-12-19 11:38 ` Christoph Hellwig
2016-12-20 14:17 ` Brian Foster
2016-12-20 21:45 ` Dave Chinner
2016-12-15 22:09 ` Dave Chinner
2016-12-16 8:20 ` Christoph Hellwig [this message]
2017-01-04 6:32 ` Darrick J. Wong
2017-01-04 8:50 ` Christoph Hellwig
2016-12-13 15:59 ` [PATCH 2/4] xfs: calculate minleft correctly for bmap allocations Christoph Hellwig
2016-12-14 18:24 ` Brian Foster
2016-12-13 15:59 ` [PATCH 3/4] xfs: adjust allocation length in xfs_alloc_space_available Christoph Hellwig
2016-12-14 18:24 ` Brian Foster
2016-12-14 19:37 ` Christoph Hellwig
2016-12-15 20:41 ` Libor Klepáč
2016-12-16 8:20 ` Christoph Hellwig
2016-12-16 0:28 ` Dave Chinner
2016-12-16 8:25 ` Christoph Hellwig
2016-12-18 23:55 ` Dave Chinner
2016-12-13 15:59 ` [PATCH 4/4] xfs: don't rely on ->total " Christoph Hellwig
2016-12-14 18:30 ` Brian Foster
2016-12-14 19:38 ` Christoph Hellwig
2016-12-14 21:51 ` Brian Foster
2016-12-15 8:55 ` Christoph Hellwig
2016-12-15 12:00 ` Brian Foster
2016-12-14 10:51 ` minleft fixes Eryu Guan
2016-12-15 10:24 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216082044.GB32288@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.