All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Kyle McMartin <kyle@redhat.com>, David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] perf trace: Check if MAP_32BIT is defined (again)
Date: Fri, 16 Dec 2016 11:02:47 -0300	[thread overview]
Message-ID: <20161216140247.GK6866@kernel.org> (raw)
In-Reply-To: <1481831814-23683-1-git-send-email-jolsa@kernel.org>

Em Thu, Dec 15, 2016 at 08:56:54PM +0100, Jiri Olsa escreveu:
> There might be systems where MAP_32BIT is not defined,
> like some some RHEL7 powerpc versions.
> 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Cc: Kyle McMartin <kyle@redhat.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Fixes: 277cf08f3feb ("perf trace beauty mmap: Fix defines for non !x86_64")

Ouch, so we need what was removed in:

Fixes: 256763b01741 ("perf trace beauty mmap: Add more conditional defines")

I.e. the ifdef at the switch case entry, not the removal of the
conditional definition expecting that it would be available in the arch
header, as in some cases those are not there. So I'm replacing the Fixme
cset, ok?

Thanks for taking the time to fill in that tag, appreciated!

Also this all needs a revamp to support cross 'perf trace'ing, i.e.
collecting a file on arch A and doing 'perf trace -i perf.data' on a
different machine with a CPU fo a different arch, where either per arch
beautifiers are needed or a dynamic switch, i.e. the value for some
define is different between archs....

Patch applied, thanks,

- Arnaldo


> Link: http://lkml.kernel.org/n/tip-qp5uczb0ln480l47xbv406cw@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/trace/beauty/mmap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/trace/beauty/mmap.c b/tools/perf/trace/beauty/mmap.c
> index fd710ab33684..af1cfde6b97b 100644
> --- a/tools/perf/trace/beauty/mmap.c
> +++ b/tools/perf/trace/beauty/mmap.c
> @@ -42,7 +42,9 @@ static size_t syscall_arg__scnprintf_mmap_flags(char *bf, size_t size,
>  
>  	P_MMAP_FLAG(SHARED);
>  	P_MMAP_FLAG(PRIVATE);
> +#ifdef MAP_32BIT
>  	P_MMAP_FLAG(32BIT);
> +#endif
>  	P_MMAP_FLAG(ANONYMOUS);
>  	P_MMAP_FLAG(DENYWRITE);
>  	P_MMAP_FLAG(EXECUTABLE);
> -- 
> 2.7.4

  reply	other threads:[~2016-12-16 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 19:56 Jiri Olsa
2016-12-16 14:02 ` Arnaldo Carvalho de Melo [this message]
2016-12-16 14:15   ` Jiri Olsa
2016-12-20 19:29 ` [tip:perf/urgent] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161216140247.GK6866@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kyle@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --subject='Re: [PATCH] perf trace: Check if MAP_32BIT is defined (again)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.