From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757202AbcLPOQG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 16 Dec 2016 09:16:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23415 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1759600AbcLPOQA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 16 Dec 2016 09:16:00 -0500
Date: Fri, 16 Dec 2016 15:15:54 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Kyle McMartin <kyle@redhat.com>,
        David Ahern <dsahern@gmail.com>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] perf trace: Check if MAP_32BIT is defined (again)
Message-ID: <20161216141554.GA5218@krava>
References: <1481831814-23683-1-git-send-email-jolsa@kernel.org>
 <20161216140247.GK6866@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161216140247.GK6866@kernel.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 16 Dec 2016 14:15:57 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 16, 2016 at 11:02:47AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 15, 2016 at 08:56:54PM +0100, Jiri Olsa escreveu:
> > There might be systems where MAP_32BIT is not defined,
> > like some some RHEL7 powerpc versions.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: Kyle McMartin <kyle@redhat.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Fixes: 277cf08f3feb ("perf trace beauty mmap: Fix defines for non !x86_64")
> 
> Ouch, so we need what was removed in:
> 
> Fixes: 256763b01741 ("perf trace beauty mmap: Add more conditional defines")
> 
> I.e. the ifdef at the switch case entry, not the removal of the
> conditional definition expecting that it would be available in the arch
> header, as in some cases those are not there. So I'm replacing the Fixme
> cset, ok?

sure, ok

> 
> Thanks for taking the time to fill in that tag, appreciated!
> 
> Also this all needs a revamp to support cross 'perf trace'ing, i.e.
> collecting a file on arch A and doing 'perf trace -i perf.data' on a
> different machine with a CPU fo a different arch, where either per arch
> beautifiers are needed or a dynamic switch, i.e. the value for some
> define is different between archs....
> 
> Patch applied, thanks,

thanks,
jirka