Re: [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

[Roger Pau Monne <roger.pau@citrix.com>]

On Fri, Dec 16, 2016 at 02:28:54PM +0000, Roger Pau Monne wrote:
> On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote:
> > >>> On 30.11.16 at 17:49, <roger.pau@citrix.com> wrote:
> > > --- a/xen/arch/x86/setup.c
> > > +++ b/xen/arch/x86/setup.c
> > > @@ -187,6 +187,35 @@ static void __init parse_acpi_param(char *s)
> > >      }
> > >  }
> > >  
> > > +/*
> > > + * List of parameters that affect Dom0 creation:
> > > + *
> > > + *  - hvm               Create a PVHv2 Dom0.
> > > + *  - shadow            Use shadow paging for Dom0.
> > > + */
> > > +static bool __initdata dom0_hvm;
> > > +static void __init parse_dom0_param(char *s)
> > > +{
> > > +    char *ss;
> > > +
> > > +    do {
> > > +
> > > +        ss = strchr(s, ',');
> > > +        if ( ss )
> > > +            *ss = '\0';
> > > +
> > > +        if ( !strcmp(s, "hvm") )
> > > +            dom0_hvm = true;
> > > +#ifdef CONFIG_SHADOW_PAGING
> > > +        else if ( !strcmp(s, "shadow") )
> > > +            opt_dom0_shadow = true;
> > > +#endif
> > > +
> > > +        s = ss + 1;
> > > +    } while ( ss );
> > > +}
> > > +custom_param("dom0", parse_dom0_param);
> > 
> > I continue to think that this should live in domain_build.c, and
> > dom0_hvm be the one off variable which needs to be global. After
> > all we intend to extend the "dom0=" quite a bit (presumably to
> > subsume everything which the various "dom0..." options now do),
> > and all that stuff lives there anyway.

In fact opt_dom0_shadow is only going to be needed by setup.c after the removal
of it's usage by PV Dom0, so I think it's better to keep parse_dom0_param in
setup.c.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel