From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com, jbacik@fb.com,
eric.dumazet@gmail.com, raigatgoog@gmail.com
Subject: Re: [PATCH net-next 0/2] inet: Fixes for inet_csk_get_port and soreusport
Date: Sat, 17 Dec 2016 11:13:33 -0500 (EST) [thread overview]
Message-ID: <20161217.111333.1879745595587471743.davem@davemloft.net> (raw)
In-Reply-To: <20161215005416.1561632-1-tom@herbertland.com>
From: Tom Herbert <tom@herbertland.com>
Date: Wed, 14 Dec 2016 16:54:14 -0800
> This patch set fixes a couple of issues I noticed while debugging our
> softlockup issue in inet_csk_get_port.
>
> - Don't allow jump into port scan in inet_csk_get_port if function
> was called with non-zero port number (looking up explicit port
> number).
> - When inet_csk_get_port is called with zero port number (ie. perform
> scan) an reuseport is set on the socket, don't match sockets that
> also have reuseport set. The intent from the user should be
> to get a new port number and then explictly bind other
> sockets to that number using soreuseport.
>
> Tested:
>
> Ran first patch on production workload with no ill effect.
>
> For second patch, ran a little listener application and first
> demonstrated that unbound sockets with soreuseport can indeed
> be bound to unrelated soreuseport sockets.
Series applied, thanks Tom.
prev parent reply other threads:[~2016-12-17 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 0:54 [PATCH net-next 0/2] inet: Fixes for inet_csk_get_port and soreusport Tom Herbert
2016-12-15 0:54 ` [PATCH net-next 1/2] inet: Don't go into port scan when looking for specific bind port Tom Herbert
2016-12-15 0:54 ` [PATCH net-next 2/2] inet: Fix get port to handle zero port number with soreuseport set Tom Herbert
2016-12-17 16:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161217.111333.1879745595587471743.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=raigatgoog@gmail.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.