All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] irqchip: st: fix defined but not used compilation warning
@ 2016-12-17  0:29 Jérémy Lefaure
  2016-12-19 10:00 ` [tip:irq/urgent] irqchip/st: Mark st_irq_syscfg_resume() __maybe_unused tip-bot for Jérémy Lefaure
  0 siblings, 1 reply; 2+ messages in thread
From: Jérémy Lefaure @ 2016-12-17  0:29 UTC (permalink / raw)
  To: Thomas Gleixner, Jason Cooper, Marc Zyngier
  Cc: linux-kernel, Jérémy Lefaure

When CONFIG_PM_SLEEP is disabled, the compiler raises a warning on
st_irq_syscfg_resume:

drivers/irqchip/irq-st.c:183:12: warning: 'st_irq_syscfg_resume' defined
but not used [-Wunused-function]
 static int st_irq_syscfg_resume(struct device *dev)
             ^~~~~~~~~~~~~~~~~~~~

Adding __maybe_unused to the declaration of this functions removes the
warning.

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
 drivers/irqchip/irq-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-st.c b/drivers/irqchip/irq-st.c
index 9af48a85c16f..5e0e250db0be 100644
--- a/drivers/irqchip/irq-st.c
+++ b/drivers/irqchip/irq-st.c
@@ -180,7 +180,7 @@ static int st_irq_syscfg_probe(struct platform_device *pdev)
 	return st_irq_syscfg_enable(pdev);
 }
 
-static int st_irq_syscfg_resume(struct device *dev)
+static int __maybe_unused st_irq_syscfg_resume(struct device *dev)
 {
 	struct st_irq_syscfg *ddata = dev_get_drvdata(dev);
 
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:irq/urgent] irqchip/st: Mark st_irq_syscfg_resume() __maybe_unused
  2016-12-17  0:29 [PATCH] irqchip: st: fix defined but not used compilation warning Jérémy Lefaure
@ 2016-12-19 10:00 ` tip-bot for Jérémy Lefaure
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jérémy Lefaure @ 2016-12-19 10:00 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: jason, linux-kernel, tglx, marc.zyngier, jeremy.lefaure, mingo, hpa

Commit-ID:  f357563f958df06cd9ea9e614cdba30578bb08b1
Gitweb:     http://git.kernel.org/tip/f357563f958df06cd9ea9e614cdba30578bb08b1
Author:     Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
AuthorDate: Fri, 16 Dec 2016 19:29:27 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 19 Dec 2016 10:55:43 +0100

irqchip/st: Mark st_irq_syscfg_resume() __maybe_unused

When CONFIG_PM_SLEEP is disabled, the compiler raises a warning on
st_irq_syscfg_resume:

drivers/irqchip/irq-st.c:183:12: warning: 'st_irq_syscfg_resume' defined
but not used [-Wunused-function]
 static int st_irq_syscfg_resume(struct device *dev)
             ^~~~~~~~~~~~~~~~~~~~

Annotate the function with __maybe_unused.

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/20161217002927.31947-1-jeremy.lefaure@lse.epita.fr
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 drivers/irqchip/irq-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-st.c b/drivers/irqchip/irq-st.c
index 9af48a8..5e0e250 100644
--- a/drivers/irqchip/irq-st.c
+++ b/drivers/irqchip/irq-st.c
@@ -180,7 +180,7 @@ static int st_irq_syscfg_probe(struct platform_device *pdev)
 	return st_irq_syscfg_enable(pdev);
 }
 
-static int st_irq_syscfg_resume(struct device *dev)
+static int __maybe_unused st_irq_syscfg_resume(struct device *dev)
 {
 	struct st_irq_syscfg *ddata = dev_get_drvdata(dev);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-12-19 10:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-17  0:29 [PATCH] irqchip: st: fix defined but not used compilation warning Jérémy Lefaure
2016-12-19 10:00 ` [tip:irq/urgent] irqchip/st: Mark st_irq_syscfg_resume() __maybe_unused tip-bot for Jérémy Lefaure

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.