All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package
@ 2016-11-27 16:16 Romain Naour
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository Romain Naour
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Romain Naour @ 2016-11-27 16:16 UTC (permalink / raw)
  To: buildroot

This package provide a header file which will be used by
Google-breakpad package. This avoid using depot-tools script to fetch
all third parties used by Google-breakpad.

Use the version corresponding to the Google-breakpad svn revision 1373:
http://linux-syscall-support.googlecode.com/svn/trunk/lss at 24 829466d3-f3f5-3ae4-62ad-de35cf9bba21

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Pascal Huerst <pascal.huerst@gmail.com>
Cc: Frank Hunleth <fhunleth@troodon-software.com>
---
 package/Config.in                                  |  1 +
 package/linux-syscall-support/Config.in            |  8 ++++++
 .../linux-syscall-support.hash                     |  2 ++
 .../linux-syscall-support/linux-syscall-support.mk | 31 ++++++++++++++++++++++
 4 files changed, 42 insertions(+)
 create mode 100644 package/linux-syscall-support/Config.in
 create mode 100644 package/linux-syscall-support/linux-syscall-support.hash
 create mode 100644 package/linux-syscall-support/linux-syscall-support.mk

diff --git a/package/Config.in b/package/Config.in
index b076dfd..d7632c5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1413,6 +1413,7 @@ menu "Miscellaneous"
 	source "package/gr-osmosdr/Config.in"
 	source "package/gsettings-desktop-schemas/Config.in"
 	source "package/haveged/Config.in"
+	source "package/linux-syscall-support/Config.in"
 	source "package/mcrypt/Config.in"
 	source "package/mobile-broadband-provider-info/Config.in"
 	source "package/qemu/Config.in"
diff --git a/package/linux-syscall-support/Config.in b/package/linux-syscall-support/Config.in
new file mode 100644
index 0000000..323dfbd
--- /dev/null
+++ b/package/linux-syscall-support/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LINUX_SYSCALL_SUPPORT
+	bool "linux-syscall-support (lss)"
+	help
+	  This project provides a header file that can be included into
+	  your application whenever you need to make direct system
+	  calls.
+
+	  https://chromium.googlesource.com/linux-syscall-support/
diff --git a/package/linux-syscall-support/linux-syscall-support.hash b/package/linux-syscall-support/linux-syscall-support.hash
new file mode 100644
index 0000000..e800e8a
--- /dev/null
+++ b/package/linux-syscall-support/linux-syscall-support.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 3ac36d3f3cef7a3a111ea61b04b470282ec15ccc27d03a117e13ac0ab9973ba8  linux-syscall-support-e6c7682c40c27527894fbb8bcba38f77edbbb6b7.tar.gz
diff --git a/package/linux-syscall-support/linux-syscall-support.mk b/package/linux-syscall-support/linux-syscall-support.mk
new file mode 100644
index 0000000..010b8f0
--- /dev/null
+++ b/package/linux-syscall-support/linux-syscall-support.mk
@@ -0,0 +1,31 @@
+################################################################################
+#
+# linux-syscall-support
+#
+################################################################################
+
+# Use the same version that the one used by Google-breakpad 1373
+LINUX_SYSCALL_SUPPORT_VERSION = e6c7682c40c27527894fbb8bcba38f77edbbb6b7
+LINUX_SYSCALL_SUPPORT_SITE = https://chromium.googlesource.com/linux-syscall-support
+LINUX_SYSCALL_SUPPORT_SITE_METHOD = git
+LINUX_SYSCALL_SUPPORT_LICENSE = BSD-3c
+LINUX_SYSCALL_SUPPORT_LICENSE_FILES = linux_syscall_support.h
+
+# Provide only one header file.
+LINUX_SYSCALL_SUPPORT_INSTALL_TARGET = NO
+LINUX_SYSCALL_SUPPORT_INSTALL_STAGING = YES
+
+define LINUX_SYSCALL_SUPPORT_HOST_INSTALL
+	$(INSTALL) -D -m 0644 $(@D)/linux_syscall_support.h \
+		$(HOST_DIR)/usr/include/linux_syscall_support.h
+endef
+HOST_LINUX_SYSCALL_SUPPORT_POST_INSTALL_HOOKS += LINUX_SYSCALL_SUPPORT_HOST_INSTALL
+
+define LINUX_SYSCALL_SUPPORT_STAGING_INSTALL
+	$(INSTALL) -D -m 0644 $(@D)/linux_syscall_support.h \
+		$(STAGING_DIR)/usr/include/linux_syscall_support.h
+endef
+LINUX_SYSCALL_SUPPORT_POST_INSTALL_STAGING_HOOKS += LINUX_SYSCALL_SUPPORT_STAGING_INSTALL
+
+$(eval $(host-generic-package))
+$(eval $(generic-package))
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository
  2016-11-27 16:16 [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package Romain Naour
@ 2016-11-27 16:16 ` Romain Naour
  2016-11-28 19:37   ` Romain Naour
                     ` (2 more replies)
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 3/3] package/google-breakpad: bump to the latest version Romain Naour
  2016-12-17 15:14 ` [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package Thomas Petazzoni
  2 siblings, 3 replies; 10+ messages in thread
From: Romain Naour @ 2016-11-27 16:16 UTC (permalink / raw)
  To: buildroot

Google-breakpad moved to a new git repository last year and the old svn
repository has been deleted. So, the Buildroot archive mirror is used.

svn: E160013: Unable to connect to a repository at URL 'http://google-breakpad.googlecode.com/svn/trunk'
svn: E160013: '/svn/trunk' path not found
--2016-11-27 10:42:34--  http://sources.buildroot.net/google-breakpad-1373.tar.gz

Swith to the git repository using the git hash corresponding to the
1373 svn revision. But there is an issue with the third parties...
Some of them are not bundled with Google-breakpad or as git submodule.
Even worst, the google-breakpad source code use #include
"third_party/lss" directly, so we can't provide missing third parties
with an external package.

That's why the linux-syscall-support package was added to Buildroot,
it provide the missing linux_syscall_support.h file which is must be
copied to src/third_party/lss/ in the Google-breakpad sources.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Pascal Huerst <pascal.huerst@gmail.com>
Cc: Frank Hunleth <fhunleth@troodon-software.com>
---
 package/google-breakpad/Config.in            |  3 ++-
 package/google-breakpad/google-breakpad.hash |  2 ++
 package/google-breakpad/google-breakpad.mk   | 25 +++++++++++++++++++++----
 3 files changed, 25 insertions(+), 5 deletions(-)
 create mode 100644 package/google-breakpad/google-breakpad.hash

diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
index c800974..5c3f2e8 100644
--- a/package/google-breakpad/Config.in
+++ b/package/google-breakpad/Config.in
@@ -10,6 +10,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	select BR2_PACKAGE_LINUX_SYSCALL_SUPPORT
 	help
 	  Google-Breakpad is a library and tool suite that allows you
 	  to distribute an application to users with compiler-provided
@@ -29,7 +30,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
 	  needed to extract the debugging symbols from target
 	  binaries.
 
-	  http://code.google.com/p/google-breakpad/
+	  https://chromium.googlesource.com/breakpad/breakpad
 
 comment "google-breakpad requires a glibc or uClibc toolchain w/ wchar, thread, C++ enabled"
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
diff --git a/package/google-breakpad/google-breakpad.hash b/package/google-breakpad/google-breakpad.hash
new file mode 100644
index 0000000..b66f43d
--- /dev/null
+++ b/package/google-breakpad/google-breakpad.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 25466aac60b83b231ce03d1540b1f8528c02ddaa76b08aed779084b145f07516 google-breakpad-7883a8308274cc37847e4ff3b995a327588fe034.tar.gz
diff --git a/package/google-breakpad/google-breakpad.mk b/package/google-breakpad/google-breakpad.mk
index 7a88c76..0805c25 100644
--- a/package/google-breakpad/google-breakpad.mk
+++ b/package/google-breakpad/google-breakpad.mk
@@ -4,16 +4,33 @@
 #
 ################################################################################
 
-GOOGLE_BREAKPAD_VERSION = 1373
-GOOGLE_BREAKPAD_SITE = http://google-breakpad.googlecode.com/svn/trunk
-GOOGLE_BREAKPAD_SITE_METHOD = svn
+GOOGLE_BREAKPAD_VERSION = 7883a8308274cc37847e4ff3b995a327588fe034
+GOOGLE_BREAKPAD_SITE = https://chromium.googlesource.com/breakpad/breakpad
+GOOGLE_BREAKPAD_SITE_METHOD = git
 GOOGLE_BREAKPAD_CONF_OPTS = --disable-processor --disable-tools
 # Only a static library is installed
 GOOGLE_BREAKPAD_INSTALL_TARGET = NO
 GOOGLE_BREAKPAD_INSTALL_STAGING = YES
 GOOGLE_BREAKPAD_LICENSE = BSD-3c
 GOOGLE_BREAKPAD_LICENSE_FILES = LICENSE
-GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad
+GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad linux-syscall-support
+
+HOST_GOOGLE_BREAKPAD_DEPENDENCIES = host-linux-syscall-support 
+
+# Avoid using depot-tools to download this file.
+define HOST_GOOGLE_BREAKPAD_LSS
+	$(INSTALL) -D -m 0644 \
+		$(HOST_DIR)/usr/include/linux_syscall_support.h \
+		$(@D)/src/third_party/lss/linux_syscall_support.h
+endef
+HOST_GOOGLE_BREAKPAD_POST_EXTRACT_HOOKS += HOST_GOOGLE_BREAKPAD_LSS
+
+define GOOGLE_BREAKPAD_LSS
+	$(INSTALL) -D -m 0644 \
+		$(STAGING_DIR)/usr/include/linux_syscall_support.h \
+		$(@D)/src/third_party/lss/linux_syscall_support.h
+endef
+GOOGLE_BREAKPAD_POST_EXTRACT_HOOKS += GOOGLE_BREAKPAD_LSS
 
 define GOOGLE_BREAKPAD_EXTRACT_SYMBOLS
 	$(EXTRA_ENV) package/google-breakpad/gen-syms.sh $(STAGING_DIR) \
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 3/3] package/google-breakpad: bump to the latest version
  2016-11-27 16:16 [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package Romain Naour
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository Romain Naour
@ 2016-11-27 16:16 ` Romain Naour
  2016-12-17 15:34   ` Thomas Petazzoni
  2016-12-17 15:14 ` [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package Thomas Petazzoni
  2 siblings, 1 reply; 10+ messages in thread
From: Romain Naour @ 2016-11-27 16:16 UTC (permalink / raw)
  To: buildroot

This version add the C++11 support and microdump.

Add the C++11 dependency since it's now mendatory.
Use the same linux-syscall-support version as the one defined by DEPS
file in the Google-breakpad sources.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Pascal Huerst <pascal.huerst@gmail.com>
Cc: Frank Hunleth <fhunleth@troodon-software.com>
---
 package/google-breakpad/Config.in                        | 6 ++++--
 package/google-breakpad/google-breakpad.hash             | 2 +-
 package/google-breakpad/google-breakpad.mk               | 2 +-
 package/linux-syscall-support/linux-syscall-support.hash | 2 +-
 package/linux-syscall-support/linux-syscall-support.mk   | 4 ++--
 5 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
index 5c3f2e8..31ca422 100644
--- a/package/google-breakpad/Config.in
+++ b/package/google-breakpad/Config.in
@@ -6,6 +6,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 config BR2_PACKAGE_GOOGLE_BREAKPAD
 	bool "google-breakpad"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
@@ -32,8 +33,9 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
 
 	  https://chromium.googlesource.com/breakpad/breakpad
 
-comment "google-breakpad requires a glibc or uClibc toolchain w/ wchar, thread, C++ enabled"
+comment "google-breakpad requires a glibc or uClibc toolchain w/ wchar, thread, C++, gcc >= 4.7"
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS || \
-		!(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
+		!(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC) || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
diff --git a/package/google-breakpad/google-breakpad.hash b/package/google-breakpad/google-breakpad.hash
index b66f43d..79e8d08 100644
--- a/package/google-breakpad/google-breakpad.hash
+++ b/package/google-breakpad/google-breakpad.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 25466aac60b83b231ce03d1540b1f8528c02ddaa76b08aed779084b145f07516 google-breakpad-7883a8308274cc37847e4ff3b995a327588fe034.tar.gz
+sha256 6f444233e88957c30cc2d5497ee9d72d104122ce2c25a7ef7f6be3af1b3f7353  google-breakpad-7515ab13768c7edc09f0f2ec2354dc6c928239a6.tar.gz
diff --git a/package/google-breakpad/google-breakpad.mk b/package/google-breakpad/google-breakpad.mk
index 0805c25..7a11c72 100644
--- a/package/google-breakpad/google-breakpad.mk
+++ b/package/google-breakpad/google-breakpad.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GOOGLE_BREAKPAD_VERSION = 7883a8308274cc37847e4ff3b995a327588fe034
+GOOGLE_BREAKPAD_VERSION = 7515ab13768c7edc09f0f2ec2354dc6c928239a6
 GOOGLE_BREAKPAD_SITE = https://chromium.googlesource.com/breakpad/breakpad
 GOOGLE_BREAKPAD_SITE_METHOD = git
 GOOGLE_BREAKPAD_CONF_OPTS = --disable-processor --disable-tools
diff --git a/package/linux-syscall-support/linux-syscall-support.hash b/package/linux-syscall-support/linux-syscall-support.hash
index e800e8a..3092552 100644
--- a/package/linux-syscall-support/linux-syscall-support.hash
+++ b/package/linux-syscall-support/linux-syscall-support.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 3ac36d3f3cef7a3a111ea61b04b470282ec15ccc27d03a117e13ac0ab9973ba8  linux-syscall-support-e6c7682c40c27527894fbb8bcba38f77edbbb6b7.tar.gz
+sha256 e5088b81011e30b567b6bde6bb7c22ad529c4ee8890cc5e93d58b21f2c4df56a  linux-syscall-support-3f6478ac95edf86cd3da300c2c0d34a438f5dbeb.tar.gz
diff --git a/package/linux-syscall-support/linux-syscall-support.mk b/package/linux-syscall-support/linux-syscall-support.mk
index 010b8f0..c698f64 100644
--- a/package/linux-syscall-support/linux-syscall-support.mk
+++ b/package/linux-syscall-support/linux-syscall-support.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-# Use the same version that the one used by Google-breakpad 1373
-LINUX_SYSCALL_SUPPORT_VERSION = e6c7682c40c27527894fbb8bcba38f77edbbb6b7
+# Use the same version that the one used by Google-breakpad (see DEPS file)
+LINUX_SYSCALL_SUPPORT_VERSION = 3f6478ac95edf86cd3da300c2c0d34a438f5dbeb
 LINUX_SYSCALL_SUPPORT_SITE = https://chromium.googlesource.com/linux-syscall-support
 LINUX_SYSCALL_SUPPORT_SITE_METHOD = git
 LINUX_SYSCALL_SUPPORT_LICENSE = BSD-3c
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository Romain Naour
@ 2016-11-28 19:37   ` Romain Naour
  2016-12-17 15:33   ` Thomas Petazzoni
  2017-05-28 18:14   ` Bernd Kuhls
  2 siblings, 0 replies; 10+ messages in thread
From: Romain Naour @ 2016-11-28 19:37 UTC (permalink / raw)
  To: buildroot

Hi All,

Le 27/11/2016 ? 17:16, Romain Naour a ?crit :
> Google-breakpad moved to a new git repository last year and the old svn
> repository has been deleted. So, the Buildroot archive mirror is used.
> 
> svn: E160013: Unable to connect to a repository at URL 'http://google-breakpad.googlecode.com/svn/trunk'
> svn: E160013: '/svn/trunk' path not found
> --2016-11-27 10:42:34--  http://sources.buildroot.net/google-breakpad-1373.tar.gz
> 
> Swith to the git repository using the git hash corresponding to the
> 1373 svn revision. But there is an issue with the third parties...
> Some of them are not bundled with Google-breakpad or as git submodule.
> Even worst, the google-breakpad source code use #include
> "third_party/lss" directly, so we can't provide missing third parties
> with an external package.
> 
> That's why the linux-syscall-support package was added to Buildroot,
> it provide the missing linux_syscall_support.h file which is must be
> copied to src/third_party/lss/ in the Google-breakpad sources.

Since we want a specific version of linux_syscall_support.h which is required by
Google-breakpad, linux_syscall_support.h may be added by a patch instead of
using an external package (linux-syscall-support) ?
The problem of using a patch is that we have to update it for each
Google-breakpad version bump.

Any suggestion is welcome.

Best regards,
Romain

> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Pascal Huerst <pascal.huerst@gmail.com>
> Cc: Frank Hunleth <fhunleth@troodon-software.com>
> ---
>  package/google-breakpad/Config.in            |  3 ++-
>  package/google-breakpad/google-breakpad.hash |  2 ++
>  package/google-breakpad/google-breakpad.mk   | 25 +++++++++++++++++++++----
>  3 files changed, 25 insertions(+), 5 deletions(-)
>  create mode 100644 package/google-breakpad/google-breakpad.hash
> 
> diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
> index c800974..5c3f2e8 100644
> --- a/package/google-breakpad/Config.in
> +++ b/package/google-breakpad/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
>  	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> +	select BR2_PACKAGE_LINUX_SYSCALL_SUPPORT
>  	help
>  	  Google-Breakpad is a library and tool suite that allows you
>  	  to distribute an application to users with compiler-provided
> @@ -29,7 +30,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
>  	  needed to extract the debugging symbols from target
>  	  binaries.
>  
> -	  http://code.google.com/p/google-breakpad/
> +	  https://chromium.googlesource.com/breakpad/breakpad
>  
>  comment "google-breakpad requires a glibc or uClibc toolchain w/ wchar, thread, C++ enabled"
>  	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> diff --git a/package/google-breakpad/google-breakpad.hash b/package/google-breakpad/google-breakpad.hash
> new file mode 100644
> index 0000000..b66f43d
> --- /dev/null
> +++ b/package/google-breakpad/google-breakpad.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 25466aac60b83b231ce03d1540b1f8528c02ddaa76b08aed779084b145f07516 google-breakpad-7883a8308274cc37847e4ff3b995a327588fe034.tar.gz
> diff --git a/package/google-breakpad/google-breakpad.mk b/package/google-breakpad/google-breakpad.mk
> index 7a88c76..0805c25 100644
> --- a/package/google-breakpad/google-breakpad.mk
> +++ b/package/google-breakpad/google-breakpad.mk
> @@ -4,16 +4,33 @@
>  #
>  ################################################################################
>  
> -GOOGLE_BREAKPAD_VERSION = 1373
> -GOOGLE_BREAKPAD_SITE = http://google-breakpad.googlecode.com/svn/trunk
> -GOOGLE_BREAKPAD_SITE_METHOD = svn
> +GOOGLE_BREAKPAD_VERSION = 7883a8308274cc37847e4ff3b995a327588fe034
> +GOOGLE_BREAKPAD_SITE = https://chromium.googlesource.com/breakpad/breakpad
> +GOOGLE_BREAKPAD_SITE_METHOD = git
>  GOOGLE_BREAKPAD_CONF_OPTS = --disable-processor --disable-tools
>  # Only a static library is installed
>  GOOGLE_BREAKPAD_INSTALL_TARGET = NO
>  GOOGLE_BREAKPAD_INSTALL_STAGING = YES
>  GOOGLE_BREAKPAD_LICENSE = BSD-3c
>  GOOGLE_BREAKPAD_LICENSE_FILES = LICENSE
> -GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad
> +GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad linux-syscall-support
> +
> +HOST_GOOGLE_BREAKPAD_DEPENDENCIES = host-linux-syscall-support 
> +
> +# Avoid using depot-tools to download this file.
> +define HOST_GOOGLE_BREAKPAD_LSS
> +	$(INSTALL) -D -m 0644 \
> +		$(HOST_DIR)/usr/include/linux_syscall_support.h \
> +		$(@D)/src/third_party/lss/linux_syscall_support.h
> +endef
> +HOST_GOOGLE_BREAKPAD_POST_EXTRACT_HOOKS += HOST_GOOGLE_BREAKPAD_LSS
> +
> +define GOOGLE_BREAKPAD_LSS
> +	$(INSTALL) -D -m 0644 \
> +		$(STAGING_DIR)/usr/include/linux_syscall_support.h \
> +		$(@D)/src/third_party/lss/linux_syscall_support.h
> +endef
> +GOOGLE_BREAKPAD_POST_EXTRACT_HOOKS += GOOGLE_BREAKPAD_LSS
>  
>  define GOOGLE_BREAKPAD_EXTRACT_SYMBOLS
>  	$(EXTRA_ENV) package/google-breakpad/gen-syms.sh $(STAGING_DIR) \
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package
  2016-11-27 16:16 [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package Romain Naour
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository Romain Naour
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 3/3] package/google-breakpad: bump to the latest version Romain Naour
@ 2016-12-17 15:14 ` Thomas Petazzoni
  2 siblings, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2016-12-17 15:14 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 27 Nov 2016 17:16:38 +0100, Romain Naour wrote:

> +define LINUX_SYSCALL_SUPPORT_HOST_INSTALL
> +	$(INSTALL) -D -m 0644 $(@D)/linux_syscall_support.h \
> +		$(HOST_DIR)/usr/include/linux_syscall_support.h
> +endef
> +HOST_LINUX_SYSCALL_SUPPORT_POST_INSTALL_HOOKS += LINUX_SYSCALL_SUPPORT_HOST_INSTALL
> +
> +define LINUX_SYSCALL_SUPPORT_STAGING_INSTALL
> +	$(INSTALL) -D -m 0644 $(@D)/linux_syscall_support.h \
> +		$(STAGING_DIR)/usr/include/linux_syscall_support.h
> +endef
> +LINUX_SYSCALL_SUPPORT_POST_INSTALL_STAGING_HOOKS += LINUX_SYSCALL_SUPPORT_STAGING_INSTALL

There was no reason to use post-install hooks here. Instead,
implementing directly LINUX_SYSCALL_SUPPORT_INSTALL_STAGING_CMDS and
HOST_LINUX_SYSCALL_SUPPORT_INSTALL_CMDS makes a lot more sense, since
it's a generic-package.

I've applied after fixing this, and adding a follow-up commit adding
you to the DEVELOPERS flie for this package.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository Romain Naour
  2016-11-28 19:37   ` Romain Naour
@ 2016-12-17 15:33   ` Thomas Petazzoni
  2017-05-28 18:14   ` Bernd Kuhls
  2 siblings, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2016-12-17 15:33 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 27 Nov 2016 17:16:39 +0100, Romain Naour wrote:
> Google-breakpad moved to a new git repository last year and the old svn
> repository has been deleted. So, the Buildroot archive mirror is used.
> 
> svn: E160013: Unable to connect to a repository at URL 'http://google-breakpad.googlecode.com/svn/trunk'
> svn: E160013: '/svn/trunk' path not found
> --2016-11-27 10:42:34--  http://sources.buildroot.net/google-breakpad-1373.tar.gz
> 
> Swith to the git repository using the git hash corresponding to the
> 1373 svn revision. But there is an issue with the third parties...
> Some of them are not bundled with Google-breakpad or as git submodule.
> Even worst, the google-breakpad source code use #include
> "third_party/lss" directly, so we can't provide missing third parties
> with an external package.
> 
> That's why the linux-syscall-support package was added to Buildroot,
> it provide the missing linux_syscall_support.h file which is must be
> copied to src/third_party/lss/ in the Google-breakpad sources.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Pascal Huerst <pascal.huerst@gmail.com>
> Cc: Frank Hunleth <fhunleth@troodon-software.com>
> ---
>  package/google-breakpad/Config.in            |  3 ++-
>  package/google-breakpad/google-breakpad.hash |  2 ++
>  package/google-breakpad/google-breakpad.mk   | 25 +++++++++++++++++++++----
>  3 files changed, 25 insertions(+), 5 deletions(-)
>  create mode 100644 package/google-breakpad/google-breakpad.hash

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 3/3] package/google-breakpad: bump to the latest version
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 3/3] package/google-breakpad: bump to the latest version Romain Naour
@ 2016-12-17 15:34   ` Thomas Petazzoni
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2016-12-17 15:34 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 27 Nov 2016 17:16:40 +0100, Romain Naour wrote:

> diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
> index 5c3f2e8..31ca422 100644
> --- a/package/google-breakpad/Config.in
> +++ b/package/google-breakpad/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
>  config BR2_PACKAGE_GOOGLE_BREAKPAD
>  	bool "google-breakpad"
>  	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11

You forgot to propagate this dependency to the
BR2_GOOGLE_BREAKPAD_ENABLE global option in the main Config.in file.
I've done so and applied your patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository
  2016-11-27 16:16 ` [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository Romain Naour
  2016-11-28 19:37   ` Romain Naour
  2016-12-17 15:33   ` Thomas Petazzoni
@ 2017-05-28 18:14   ` Bernd Kuhls
  2017-05-28 18:51     ` Romain Naour
  2017-05-28 20:17     ` Thomas Petazzoni
  2 siblings, 2 replies; 10+ messages in thread
From: Bernd Kuhls @ 2017-05-28 18:14 UTC (permalink / raw)
  To: buildroot

Am Sun, 27 Nov 2016 17:16:39 +0100 schrieb Romain Naour:

> +GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad linux-syscall-
support
> +
> +HOST_GOOGLE_BREAKPAD_DEPENDENCIES = host-linux-syscall-support 
> +
> +# Avoid using depot-tools to download this file.
> +define HOST_GOOGLE_BREAKPAD_LSS
> +	$(INSTALL) -D -m 0644 \
> +		$(HOST_DIR)/usr/include/linux_syscall_support.h \
> +		$(@D)/src/third_party/lss/linux_syscall_support.h
> +endef
> +HOST_GOOGLE_BREAKPAD_POST_EXTRACT_HOOKS += HOST_GOOGLE_BREAKPAD_LSS

Hi,

I do not know whether I found a bug or not while currently testing an 
allyesconfig with "make legal-info" only.

In this case the package linux-syscall-support was not installed to 
staging, therefore linux_syscall_support.h cannot be installed by 
_POST_EXTRACT_HOOKS breaking the google-breakpad-legal-info target:

/usr/bin/install: cannot stat '/home/bernd/buildroot/buildroot/output/
host/usr/i586-buildroot-linux-uclibc/sysroot/usr/include/
linux_syscall_support.h': No such file or directory

Is the legal-info target meant to be used that way, this means without 
building the package first, or do the packages have to be built before?
In this case the problem would not exist.

Regards, Bernd

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository
  2017-05-28 18:14   ` Bernd Kuhls
@ 2017-05-28 18:51     ` Romain Naour
  2017-05-28 20:17     ` Thomas Petazzoni
  1 sibling, 0 replies; 10+ messages in thread
From: Romain Naour @ 2017-05-28 18:51 UTC (permalink / raw)
  To: buildroot

Hi Bernd,

Le 28/05/2017 ? 20:14, Bernd Kuhls a ?crit :
> Am Sun, 27 Nov 2016 17:16:39 +0100 schrieb Romain Naour:
> 
>> +GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad linux-syscall-
> support
>> +
>> +HOST_GOOGLE_BREAKPAD_DEPENDENCIES = host-linux-syscall-support 
>> +
>> +# Avoid using depot-tools to download this file.
>> +define HOST_GOOGLE_BREAKPAD_LSS
>> +	$(INSTALL) -D -m 0644 \
>> +		$(HOST_DIR)/usr/include/linux_syscall_support.h \
>> +		$(@D)/src/third_party/lss/linux_syscall_support.h
>> +endef
>> +HOST_GOOGLE_BREAKPAD_POST_EXTRACT_HOOKS += HOST_GOOGLE_BREAKPAD_LSS
> 
> Hi,
> 
> I do not know whether I found a bug or not while currently testing an 
> allyesconfig with "make legal-info" only.
> 
> In this case the package linux-syscall-support was not installed to 
> staging, therefore linux_syscall_support.h cannot be installed by 
> _POST_EXTRACT_HOOKS breaking the google-breakpad-legal-info target:
> 
> /usr/bin/install: cannot stat '/home/bernd/buildroot/buildroot/output/
> host/usr/i586-buildroot-linux-uclibc/sysroot/usr/include/
> linux_syscall_support.h': No such file or directory
> 
> Is the legal-info target meant to be used that way, this means without 
> building the package first, or do the packages have to be built before?
> In this case the problem would not exist.

Thanks for the report, I reproduced the bug here.

You're right, you can generate a defconfig and then extract legal-info without
building at all.

It seems I used the wrong hook to copy the linux_syscall_support.h file.
What do you think about PRE_CONFIGURE instead ?

Best regards,
Romain

> 
> Regards, Bernd
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository
  2017-05-28 18:14   ` Bernd Kuhls
  2017-05-28 18:51     ` Romain Naour
@ 2017-05-28 20:17     ` Thomas Petazzoni
  1 sibling, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2017-05-28 20:17 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 28 May 2017 20:14:36 +0200, Bernd Kuhls wrote:

> I do not know whether I found a bug or not while currently testing an 
> allyesconfig with "make legal-info" only.
> 
> In this case the package linux-syscall-support was not installed to 
> staging, therefore linux_syscall_support.h cannot be installed by 
> _POST_EXTRACT_HOOKS breaking the google-breakpad-legal-info target:
> 
> /usr/bin/install: cannot stat '/home/bernd/buildroot/buildroot/output/
> host/usr/i586-buildroot-linux-uclibc/sysroot/usr/include/
> linux_syscall_support.h': No such file or directory
> 
> Is the legal-info target meant to be used that way, this means without 
> building the package first, or do the packages have to be built before?
> In this case the problem would not exist.

I confirm that we should be able to run "make legal-info" without doing
a build first. So, something like:

 $ make foo_defconfig
 $ make legal-info

is supposed to work.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-05-28 20:17 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-27 16:16 [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package Romain Naour
2016-11-27 16:16 ` [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository Romain Naour
2016-11-28 19:37   ` Romain Naour
2016-12-17 15:33   ` Thomas Petazzoni
2017-05-28 18:14   ` Bernd Kuhls
2017-05-28 18:51     ` Romain Naour
2017-05-28 20:17     ` Thomas Petazzoni
2016-11-27 16:16 ` [Buildroot] [PATCH for-next 3/3] package/google-breakpad: bump to the latest version Romain Naour
2016-12-17 15:34   ` Thomas Petazzoni
2016-12-17 15:14 ` [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.