All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 0/9] NFS client attribute cache performance improvements
Date: Sat, 17 Dec 2016 13:27:02 -0500	[thread overview]
Message-ID: <20161217182711.10643-1-trond.myklebust@primarydata.com> (raw)

The following patchset makes the largest difference w.r.t. NFSv4, where
we don't always ask for the full set of attributes from the server, however
there are also some tidbits for NFSv3.

With this patchset, running xfstests over NFSv4.1 shows the following
improvement in execution times:

Generic/074 now 264s, was 344s
Generic/075 now 15s was 26s
Generic/089 now 178s was 236s
Generic/112 now 14s was 25s
Generic/113 now 14s was 20s
Generic/127 now 206s was 223s
Generic/133 now 85s was 118s
Generic/247 now 27s was 43s

I saw no statistically significant performance regressions (and no functional
regressions).

For nfsstats, the client shows a significant decrease in % GETATTR and
% LOOKUP calls on the same workloads.

For 2 runs of xfstests, the numbers are:
GETATTR: now 1456511, was 2168740
LOOKUP: now 301073, was 545571
ACCESS: now 137211 was 139447


Trond Myklebust (9):
  NFSv4: Don't invalidate the directory twice
  NFSv4: Update the attribute cache info in update_changeattr
  NFSv4: Don't discard the attributes returned by asynchronous
    DELEGRETURN
  NFS: Don't revalidate the file on close if we hold a delegation
  NFS: Clean up cache validity checking
  NFS: Only look at the change attribute cache state in
    nfs_weak_revalidate()
  NFS: Fix and clean up the access cache validity checking
  NFS: Remove unused function nfs_revalidate_inode_rcu()
  NFS: Clean up nfs_attribute_timeout()

 fs/nfs/dir.c           | 23 +++++++++--------
 fs/nfs/file.c          | 12 +--------
 fs/nfs/inode.c         | 68 ++++++++++++++++++++++++++++++--------------------
 fs/nfs/internal.h      |  1 +
 fs/nfs/nfs4proc.c      | 17 +++++++++----
 include/linux/nfs_fs.h |  2 --
 6 files changed, 67 insertions(+), 56 deletions(-)

-- 
2.9.3


             reply	other threads:[~2016-12-17 18:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-17 18:27 Trond Myklebust [this message]
2016-12-17 18:27 ` [PATCH 1/9] NFSv4: Don't invalidate the directory twice Trond Myklebust
2016-12-17 18:27   ` [PATCH 2/9] NFSv4: Update the attribute cache info in update_changeattr Trond Myklebust
2016-12-17 18:27     ` [PATCH 3/9] NFSv4: Don't discard the attributes returned by asynchronous DELEGRETURN Trond Myklebust
2016-12-17 18:27       ` [PATCH 4/9] NFS: Don't revalidate the file on close if we hold a delegation Trond Myklebust
2016-12-17 18:27         ` [PATCH 5/9] NFS: Clean up cache validity checking Trond Myklebust
2016-12-17 18:27           ` [PATCH 6/9] NFS: Only look at the change attribute cache state in nfs_weak_revalidate() Trond Myklebust
2016-12-17 18:27             ` [PATCH 7/9] NFS: Fix and clean up the access cache validity checking Trond Myklebust
2016-12-17 18:27               ` [PATCH 8/9] NFS: Remove unused function nfs_revalidate_inode_rcu() Trond Myklebust
2016-12-17 18:27                 ` [PATCH 9/9] NFS: Clean up nfs_attribute_timeout() Trond Myklebust
2016-12-19 16:54   ` [PATCH 1/9] NFSv4: Don't invalidate the directory twice Anna Schumaker
2016-12-19 16:56     ` Trond Myklebust
2016-12-19 17:00       ` Trond Myklebust
2016-12-19 17:07       ` Anna Schumaker
2016-12-19 17:30         ` Trond Myklebust
2016-12-19 19:05           ` Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161217182711.10643-1-trond.myklebust@primarydata.com \
    --to=trond.myklebust@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.