From: Christoph Hellwig <hch@infradead.org>
To: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] xfs: silent -Wformat-security warning
Date: Mon, 19 Dec 2016 08:05:44 -0800 [thread overview]
Message-ID: <20161219160544.GA9994@infradead.org> (raw)
In-Reply-To: <20161219134111.5267-1-nicolas.iooss_linux@m4x.org>
On Mon, Dec 19, 2016 at 02:41:11PM +0100, Nicolas Iooss wrote:
> When building the XFS driver with clang, the compiler reports a
> -Wformat-security warning in xlog_recover_validate_buf_type() because
> xfs_warn() is being called with a non-literal string. Even though
> variable warnmsg is always initialized as a constant string without any
> '%' character, silent the warning by calling xfs_warn with "%s" format
> string.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2016-12-19 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 13:41 [PATCH 1/1] xfs: silent -Wformat-security warning Nicolas Iooss
2016-12-19 16:05 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219160544.GA9994@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.