From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933316AbcLSXch (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Dec 2016 18:32:37 -0500
Received: from mail.skyhub.de ([78.46.96.112]:38879 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932155AbcLSXce (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Dec 2016 18:32:34 -0500
Date: Tue, 20 Dec 2016 00:32:29 +0100
From: Borislav Petkov <bp@alien8.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode: Adjust ramdisk address when accessing by
 virtual address
Message-ID: <20161219233229.p5uw2thbl55o26ds@pd.tnic>
References: <1482161533-21097-1-git-send-email-boris.ostrovsky@oracle.com>
 <20161219153714.rhbpvcauc5xigzua@pd.tnic>
 <383d2984-fdd0-a198-4477-677b992fc955@oracle.com>
 <20161219164027.ejbf3h6qsnkjjezy@pd.tnic>
 <20161219180709.2tsvsebagdiyxxrs@pd.tnic>
 <f9a50117-b404-da6f-e54a-f8b40e765c1b@oracle.com>
 <20161219184340.4tzv2hg2vf3n63b7@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20161219184340.4tzv2hg2vf3n63b7@pd.tnic>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 19, 2016 at 07:43:40PM +0100, Borislav Petkov wrote:
> On Mon, Dec 19, 2016 at 01:12:25PM -0500, Boris Ostrovsky wrote:
> > IIUIC find_microcode_in_initrd() is called with paging on only on Intel
> > (which is where I observed it).
> 
> Ah, that was an important fact. Yes, I can repro it now.

Ok, questions:

* does your guest relocate the ramdisk?

I.e., do you see something like this in dmesg before the splat:

[    0.000000] RAMDISK: [mem 0x7f84c000-0x7ffcffff]
[    0.000000] Allocated new RAMDISK: [mem 0x3647a000-0x36bfd9e6]
[    0.000000] Move RAMDISK from [mem 0x7f84c000-0x7ffcf9e6] to [mem 0x3647a000-0x36bfd9e6]
	       ^^^^^^^^^^^^^^

If not, then I know what happens.

Also, does it work if you change these lines:

        if (!use_pa && relocated_ramdisk)
                start = initrd_start;

to:

        if (!use_pa)
                start = initrd_start;


Because if that works, I can actually simplify that function radically.

But more tomorrow.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.