From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756445AbcLUDUe (ORCPT ); Tue, 20 Dec 2016 22:20:34 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51732 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbcLUDUa (ORCPT ); Tue, 20 Dec 2016 22:20:30 -0500 Date: Tue, 20 Dec 2016 22:20:20 -0500 (EST) Message-Id: <20161220.222020.1448709395205678279.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, gregkh@linuxfoundation.org, aaro.koskinen@iki.fi, nevola@gmail.com, tremyfr@gmail.com, asbjorn@asbjorn.st, jarod@redhat.com, bhaktipriya96@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: octeon: Call SET_NETDEV_DEV() From: David Miller In-Reply-To: References: <20161215011326.8852-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Dec 2016 18:21:06 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Tue, 20 Dec 2016 17:02:37 -0800 > On 12/14/2016 05:13 PM, Florian Fainelli wrote: >> The Octeon driver calls into PHYLIB which now checks for >> net_device->dev.parent, so make sure we do set it before calling into >> any MDIO/PHYLIB related function. >> >> Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a different owner") >> Reported-by: Aaro Koskinen >> Signed-off-by: Florian Fainelli > > Greg, David, since this is a fix for a regression introduced in the net > tree, it may make sense that David take it via his tree. Since the change in question is in Linus's tree, it's equally valid for Greg to take it as well. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] staging: octeon: Call SET_NETDEV_DEV() Date: Tue, 20 Dec 2016 22:20:20 -0500 (EST) Message-ID: <20161220.222020.1448709395205678279.davem@davemloft.net> References: <20161215011326.8852-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, asbjorn@asbjorn.st, aaro.koskinen@iki.fi, netdev@vger.kernel.org, nevola@gmail.com, bhaktipriya96@gmail.com, jarod@redhat.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tremyfr@gmail.com To: f.fainelli@gmail.com Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org From: Florian Fainelli Date: Tue, 20 Dec 2016 17:02:37 -0800 > On 12/14/2016 05:13 PM, Florian Fainelli wrote: >> The Octeon driver calls into PHYLIB which now checks for >> net_device->dev.parent, so make sure we do set it before calling into >> any MDIO/PHYLIB related function. >> >> Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a different owner") >> Reported-by: Aaro Koskinen >> Signed-off-by: Florian Fainelli > > Greg, David, since this is a fix for a regression introduced in the net > tree, it may make sense that David take it via his tree. Since the change in question is in Linus's tree, it's equally valid for Greg to take it as well.