From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Andy Yan , Fabio Estevam , Jose Abreu , Kieran Bingham , Russell King , Ulrich Hecht , Vladimir Zapolskiy , linux-renesas-soc@vger.kernel.org Subject: [PATCH v2 00/29] R-Car Gen3 HDMI output support Date: Tue, 20 Dec 2016 03:33:31 +0200 Message-Id: <20161220013400.28317-1-laurent.pinchart+renesas@ideasonboard.com> List-ID: Hello, This patch series implements support for the HDMI output on Renesas R-Car Gen3 SoCs, and more specifically on the R-Car H3. R-Car Gen3 SoCs include one or multiple Synopsys DWC HDMI TX controllers. The series thus starts with 20 cleanup or feature patches for the dw-hdmi driver. Patches 01/29 to 05/29 are small miscellaneous cleanups. Patch 06/29 fixes a crash when the HPD interrupt is generated before the bridge gets attached to a DRM device. Patch 07/29 then starts refactoring the API towards platform glue by moving common I/O and clock resource allocation to common code. Patches 08/29 and 09/29 continue by moving connector creation to the bridge attach operation to comply with the DRM bridge API. Patch 10/29 implements a new API for platform glue to register the bridge with the DRM core, for platform that doesn't use the component framework. Patches 11/29 to 20/29 refactor platform support in the dw-hdmi driver. This is the largest change compared to v1. Patch 11/29 is a small cleanup and patch 12/29 a register rename to match available documentation. Patch 13/29 starts making use of the hardware product ID to reject invalid devices and patch 14/29 and 15/29 continue with refactoring of audio DMA detection and overflow workaround handling based on the device version. Patch 16/29 adds PHY type detection at runtime and patch 17/29 reworks PHY power handling accordingly. Patches 18/29 and 19/29 add support for custom PHYs, and patch 20/29 finally removes the now unneeded device type field from platform data. The next three patches add glue code for the DWC HDMI on Renesas R-Car Gen3 platforms. Patch 21/29 rework the DWC HDMI DT bindings to make them more modular, and patch 22/29 makes use of them to document the R-Car Gen DWC HDMI TX DT bindings. Patch 23/29 then implements the platform glue code. The next three patches implement support for the R8A7795 HDMI outputs in the R-Car DU driver. Patch 24/29 fixes a bug that makes the driver defer probe forever if an encoder is disabled. Patch 25/29 implements DPLL support to generate more precise clocks required by the HDMI controller, and patch 26/29 then enables the two HDMI output on the R-Car H3 SoC. The last three patches enable the HDMI outputs on the H3 Salvator-X board by adding the HDMI encoders to the R-Car H3 DT (27/29), adding HDMI connectors and enabling the encoders (28/29) and adding the external dot clocks (29/29). I have tested the code on a Renesas Salvator-X H3 board, a Rockchip RK3288 Rock2 board and an IMX6Q Rex Pro board. No issue due to the dw-hdmi rework have been observed. More improvements to the dw-hdmi driver would be beneficial. The PHY modularization is based on the limited understanding of the HDMI PHYs used on the three supported platforms and will possibly be enhanced later when adding support for more platforms. The PHY used on Renesas platforms is probably generic, but due to limited documentation and unavailability of public datasheets from Synopsys I can't at the moment determine if the code could be shared. I propose addressing this when another platform will be merged in mainline using the same PHY. The DT bindings would also benefit from a standardized definition of the ports, and the reg-io-width property could possibly be deprecated in favour of encoding the information in platform glue code. The patch series is however big enough as is to be submitted for review and merge before the dw-hdmi driver achieves perfection. Kieran Bingham (4): drm: bridge: dw-hdmi: Remove unused function parameter drm: bridge: dw-hdmi: Remove PHY configuration resolution parameter drm: bridge: dw-hdmi: Add support for custom PHY configuration drm: bridge: dw-hdmi: Remove device type from platform data Koji Matsuoka (4): drm: rcar-du: Add Gen3 HDMI encoder support drm: rcar-du: Add DPLL support drm: rcar-du: Add HDMI outputs to R8A7795 device description arm64: dts: r8a7795: salvator-x: Enable HDMI outputs Laurent Pinchart (20): drm: bridge: dw-hdmi: Merge __hdmi_phy_i2c_write and hdmi_phy_i2c_write drm: bridge: dw-hdmi: Remove unneeded arguments to bind/unbind functions drm: bridge: dw-hdmi: Embed drm_bridge in struct dw_hdmi drm: bridge: dw-hdmi: Remove encoder field from struct dw_hdmi drm: bridge: dw-hdmi: Don't forward HPD events to DRM core before attach drm: bridge: dw-hdmi: Move IRQ and IO resource allocation to common code drm: bridge: dw-hdmi: Reorder functions to prepare for next commit drm: bridge: dw-hdmi: Create connector in the bridge attach operation drm: bridge: dw-hdmi: Implement DRM bridge registration drm: bridge: dw-hdmi: Rename CONF0 SPARECTRL bit to SVSRET drm: bridge: dw-hdmi: Reject invalid product IDs drm: bridge: dw-hdmi: Detect AHB audio DMA using correct register drm: bridge: dw-hdmi: Handle overflow workaround based on device version drm: bridge: dw-hdmi: Detect PHY type at runtime drm: bridge: dw-hdmi: Refactor PHY power handling drm: bridge: dw-hdmi: Move CSC configuration out of PHY code dt-bindings: display: dw-hdmi: Clean up DT bindings documentation dt-bindings: display: renesas: Add R-Car Gen3 HDMI TX DT bindings drm: rcar-du: Skip disabled outputs arm64: dts: r8a7795: salvator-x: Add DU1 and DU2 external dot clocks Ulrich Hecht (1): arm64: dts: r8a7795: Add HDMI encoder support .../devicetree/bindings/display/bridge/dw_hdmi.txt | 85 ++-- .../bindings/display/bridge/renesas,dw-hdmi.txt | 75 +++ .../devicetree/bindings/display/imx/hdmi.txt | 51 +- .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 43 +- MAINTAINERS | 1 + arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 73 +++ arch/arm64/boot/dts/renesas/r8a7795.dtsi | 50 ++ drivers/gpu/drm/bridge/dw-hdmi.c | 557 +++++++++++++-------- drivers/gpu/drm/bridge/dw-hdmi.h | 16 +- drivers/gpu/drm/imx/dw_hdmi-imx.c | 16 +- drivers/gpu/drm/rcar-du/Kconfig | 8 + drivers/gpu/drm/rcar-du/Makefile | 1 + drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 81 ++- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 +- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 13 +- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + drivers/gpu/drm/rcar-du/rcar_du_kms.c | 7 + drivers/gpu/drm/rcar-du/rcar_du_regs.h | 23 + drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 100 ++++ drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 15 +- include/drm/bridge/dw_hdmi.h | 29 +- 21 files changed, 923 insertions(+), 326 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt create mode 100644 drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c -- Regards, Laurent Pinchart