From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757098AbcLTGHx (ORCPT ); Tue, 20 Dec 2016 01:07:53 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:37944 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbcLTGHv (ORCPT ); Tue, 20 Dec 2016 01:07:51 -0500 Date: Mon, 19 Dec 2016 22:07:48 -0800 From: Christoph Hellwig To: Keith Busch Cc: Scott Bauer , linux-nvme@lists.infradead.org, Rafael.Antognolli@intel.com, axboe@fb.com, jonathan.derrick@intel.com, viro@zeniv.linux.org.uk, hch@infradead.org, linux-kernel@vger.kernel.org, sagi@grimberg.me Subject: Re: [PATCH v3 2/5] lib: Add Sed-opal library Message-ID: <20161220060748.GA4765@infradead.org> References: <1482176149-2257-1-git-send-email-scott.bauer@intel.com> <1482176149-2257-3-git-send-email-scott.bauer@intel.com> <20161219213415.GA10634@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161219213415.GA10634@localhost.localdomain> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 19, 2016 at 04:34:15PM -0500, Keith Busch wrote: > This seems like an optional library that some environments may wish to > opt-out of building into the kernel. Any reason not to add an entry into > the Kconfig to turn this on/off? This needs to be a CONFIG_BLOCK_SED / CONFIG_BLOCK_SED_OPAL and should move to block/. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Mon, 19 Dec 2016 22:07:48 -0800 Subject: [PATCH v3 2/5] lib: Add Sed-opal library In-Reply-To: <20161219213415.GA10634@localhost.localdomain> References: <1482176149-2257-1-git-send-email-scott.bauer@intel.com> <1482176149-2257-3-git-send-email-scott.bauer@intel.com> <20161219213415.GA10634@localhost.localdomain> Message-ID: <20161220060748.GA4765@infradead.org> On Mon, Dec 19, 2016@04:34:15PM -0500, Keith Busch wrote: > This seems like an optional library that some environments may wish to > opt-out of building into the kernel. Any reason not to add an entry into > the Kconfig to turn this on/off? This needs to be a CONFIG_BLOCK_SED / CONFIG_BLOCK_SED_OPAL and should move to block/.