From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756791AbcLTGXL (ORCPT ); Tue, 20 Dec 2016 01:23:11 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:41037 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbcLTGXH (ORCPT ); Tue, 20 Dec 2016 01:23:07 -0500 Date: Mon, 19 Dec 2016 22:21:58 -0800 From: Christoph Hellwig To: Scott Bauer Cc: linux-nvme@lists.infradead.org, Rafael.Antognolli@intel.com, axboe@fb.com, keith.busch@intel.com, jonathan.derrick@intel.com, viro@zeniv.linux.org.uk, hch@infradead.org, linux-kernel@vger.kernel.org, sagi@grimberg.me Subject: Re: [PATCH v3 3/5] fs: Wire up SED/Opal to ioctl Message-ID: <20161220062158.GD4765@infradead.org> References: <1482176149-2257-1-git-send-email-scott.bauer@intel.com> <1482176149-2257-4-git-send-email-scott.bauer@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482176149-2257-4-git-send-email-scott.bauer@intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -853,6 +854,7 @@ struct file { > #ifdef CONFIG_SECURITY > void *f_security; > #endif > + struct sed_context *f_sedctx; Adding a new field to the global struct file for a block driver feature is not acceptable. And I don't really see why it would be nessecary anyway. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Mon, 19 Dec 2016 22:21:58 -0800 Subject: [PATCH v3 3/5] fs: Wire up SED/Opal to ioctl In-Reply-To: <1482176149-2257-4-git-send-email-scott.bauer@intel.com> References: <1482176149-2257-1-git-send-email-scott.bauer@intel.com> <1482176149-2257-4-git-send-email-scott.bauer@intel.com> Message-ID: <20161220062158.GD4765@infradead.org> > @@ -853,6 +854,7 @@ struct file { > #ifdef CONFIG_SECURITY > void *f_security; > #endif > + struct sed_context *f_sedctx; Adding a new field to the global struct file for a block driver feature is not acceptable. And I don't really see why it would be nessecary anyway.