From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v3 22/25] app/testpmd: add L4 items to flow
 command
Date: Tue, 20 Dec 2016 10:50:49 +0100
Message-ID: <20161220095049.GQ10340@6wind.com>
References: <cover.1481903839.git.adrien.mazarguil@6wind.com>
 <cover.1482168851.git.adrien.mazarguil@6wind.com>
 <11827edfa78272fe967e5a53451a3f48c6d7d17a.1482168851.git.adrien.mazarguil@6wind.com>
 <188971FCDA171749BED5DA74ABF3E6F03B66D499@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>
To: "Pei, Yulong" <yulong.pei@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id D7485FB11
 for <dev@dpdk.org>; Tue, 20 Dec 2016 10:50:57 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id g23so115644668wme.1
 for <dev@dpdk.org>; Tue, 20 Dec 2016 01:50:57 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <188971FCDA171749BED5DA74ABF3E6F03B66D499@shsmsx102.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Yulong,

On Tue, Dec 20, 2016 at 09:14:55AM +0000, Pei, Yulong wrote:
> Hi Adrien,
> 
> For SCTP, it may need support to set  'tag'  since in FDIR (--pkt-filter-mode=perfect) need set it when filter sctp flow.
> 
> struct sctp_hdr {
>         uint16_t src_port; /**< Source port. */
>         uint16_t dst_port; /**< Destin port. */
>         uint32_t tag;      /**< Validation tag. */
>         uint32_t cksum;    /**< Checksum. */
> } __attribute__((__packed__));
> 
> testpmd> flow create 0 ingress pattern eth / ipv4 src is 192.168.0.1 dst is 192.168.0.2 / sctp
>  src [TOKEN]: SCTP source port
>  dst [TOKEN]: SCTP destination port
>  / [TOKEN]: specify next pattern item

Sure, let's add it in a subsequent patch after this series is applied, it is
only a few lines of code in testpmd (basically like all missing protocol
fields).

-- 
Adrien Mazarguil
6WIND