From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 Date: Tue, 20 Dec 2016 15:07:09 +0100 Message-ID: <20161220140709.pxvzcm3osmbromfh@lukather> References: <20161220104038.22532-1-codekipper@gmail.com> <20161220104038.22532-3-codekipper@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vcmplzvpu7iqfdbf" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20161220104038.22532-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --vcmplzvpu7iqfdbf Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > From: Marcus Cooper > > Add the SPDIF transceiver controller block to the A31 dtsi. > > Signed-off-by: Marcus Cooper > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi > index 7370ba6c9993..559c53efa7e6 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -613,6 +613,20 @@ > reg = <0x01c20ca0 0x20>; > }; > > + spdif: spdif@01c21000 { > + #sound-dai-cells = <0>; > + compatible = "allwinner,sun6i-a31-spdif"; > + reg = <0x01c21000 0x400>; > + interrupts = ; > + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; > + resets = <&ccu RST_APB1_SPDIF>; > + clock-names = "apb", "spdif"; > + dmas = <&dma 2>, <&dma 2>; > + dma-names = "rx", "tx"; > + spdif-out = "disabled"; That property isn't documented anywhere, and doesn't seem to be used in your driver either. On a separate topic, is the channel inversion bug also found on the A31? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --vcmplzvpu7iqfdbf-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Tue, 20 Dec 2016 15:07:09 +0100 Subject: [linux-sunxi][PATCH 2/3] ARM: dts: sun6i: Add the SPDIF block to the A31 In-Reply-To: <20161220104038.22532-3-codekipper@gmail.com> References: <20161220104038.22532-1-codekipper@gmail.com> <20161220104038.22532-3-codekipper@gmail.com> Message-ID: <20161220140709.pxvzcm3osmbromfh@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper at gmail.com wrote: > From: Marcus Cooper > > Add the SPDIF transceiver controller block to the A31 dtsi. > > Signed-off-by: Marcus Cooper > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi > index 7370ba6c9993..559c53efa7e6 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -613,6 +613,20 @@ > reg = <0x01c20ca0 0x20>; > }; > > + spdif: spdif at 01c21000 { > + #sound-dai-cells = <0>; > + compatible = "allwinner,sun6i-a31-spdif"; > + reg = <0x01c21000 0x400>; > + interrupts = ; > + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; > + resets = <&ccu RST_APB1_SPDIF>; > + clock-names = "apb", "spdif"; > + dmas = <&dma 2>, <&dma 2>; > + dma-names = "rx", "tx"; > + spdif-out = "disabled"; That property isn't documented anywhere, and doesn't seem to be used in your driver either. On a separate topic, is the channel inversion bug also found on the A31? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: