Re: [PATCH] i40iw: Set 128B as the only supported RQ WQE size

[Henry Orosco <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Tue, Dec 20, 2016 at 07:30:45PM +0200, Yuval Shaia wrote:
> On Tue, Dec 20, 2016 at 10:41:18AM -0600, Henry Orosco wrote:
> > > > 
> > > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > > index 392f783..98923a8 100644
> > > > --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > > +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > > @@ -358,13 +358,16 @@ void i40iw_qp_add_qos(struct i40iw_sc_qp *qp)
> > > >   * @dev: sc device struct
> > > >   * @pd: sc pd ptr
> > > >   * @pd_id: pd_id for allocated pd
> > > > + * @abi_ver: ABI version from user context, -1 if not valid
> > > >   */
> > > >  static void i40iw_sc_pd_init(struct i40iw_sc_dev *dev,
> > > >  			     struct i40iw_sc_pd *pd,
> > > > -			     u16 pd_id)
> > > > +			     u16 pd_id,
> > > > +			     int abi_ver)
> > > 
> > > No need for new line here
> > > 
> > 
> > Not sure what you mean here.
> 
> From code-style perspective "u16 pd_id," and "int abi_ver" can be on one line.

We will opt to keep it as originally sent (one parameter per line) as this is
consistent with the rest of the file.

> 
> > 
> > > >  {
> > > >  	pd->size = sizeof(*pd);
> > > >  	pd->pd_id = pd_id;
> > > > +	pd->abi_ver = abi_ver;
> > > >  	pd->dev = dev;
> > > >  }
> > > >  
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html